[
https://issues.apache.org/jira/browse/HDFS-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189017#comment-13189017
]
Hadoop QA commented on HDFS-2803:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12511062/hdfs-2803.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated 21 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
-1 release audit. The applied patch generated 1 release audit warnings
(more than the trunk's current 0 warnings).
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1781//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1781//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1781//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1781//console
This message is automatically generated.
> Adding logging to LeaseRenewer for better lease expiration triage.
> ------------------------------------------------------------------
>
> Key: HDFS-2803
> URL: https://issues.apache.org/jira/browse/HDFS-2803
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Labels: newbie
> Attachments: hdfs-2803.txt
>
>
> It will be helpful to add some logging to LeaseRenewer when the daemon is
> terminated (Info level),
> and when the lease is renewed (Debug level). Since lacking logging, it is
> hard to know
> if a DFS client doesn't renew the lease because it hangs, or the lease
> renewer daemon is gone somehow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
