[
https://issues.apache.org/jira/browse/HDFS-13522?focusedWorklogId=754481&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-754481
]
ASF GitHub Bot logged work on HDFS-13522:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/22 09:28
Start Date: 08/Apr/22 09:28
Worklog Time Spent: 10m
Work Description: tomscut commented on code in PR #4127:
URL: https://github.com/apache/hadoop/pull/4127#discussion_r845916975
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -1380,8 +1437,9 @@ private static boolean isExpectedValue(Object
expectedValue, Object value) {
final CallerContext originContext = CallerContext.getCurrent();
for (final T location : locations) {
String nsId = location.getNameserviceId();
+ boolean isObserverRead = observerReadEnabled && isReadCall(m);
final List<? extends FederationNamenodeContext> namenodes =
- getNamenodesForNameservice(nsId);
+ msync(nsId, ugi, isObserverRead);
Review Comment:
If `observerReadEnabled` is a global config, assume that there are two NS.
NS1 supports msync, but NS2 does not. If NS1 is executed, a
`NoSuchMethodException` may be thrown, causing the entire request to fail.
Maybe we should also add a NS level config, such as
`nsToObserverReadEnabled`. Here's how we do it.
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java:
##########
@@ -79,6 +79,8 @@
String DFS_NAMENODE_HTTPS_ADDRESS_KEY = "dfs.namenode.https-address";
String DFS_HA_NAMENODES_KEY_PREFIX = "dfs.ha.namenodes";
int DFS_NAMENODE_RPC_PORT_DEFAULT = 8020;
+ String DFS_OBSERVER_READ_ENABLE = "dfs.observer.read.enable";
+ boolean DFS_OBSERVER_READ_ENABLE_DEFAULT = true;
Review Comment:
Hi @simbadzina , should the default here be false?
Issue Time Tracking
-------------------
Worklog Id: (was: 754481)
Time Spent: 5h (was: 4h 50m)
> RBF: Support observer node from Router-Based Federation
> -------------------------------------------------------
>
> Key: HDFS-13522
> URL: https://issues.apache.org/jira/browse/HDFS-13522
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: federation, namenode
> Reporter: Erik Krogen
> Assignee: Simbarashe Dzinamarira
> Priority: Major
> Labels: pull-request-available
> Attachments: HDFS-13522.001.patch, HDFS-13522.002.patch,
> HDFS-13522_WIP.patch, RBF_ Observer support.pdf, Router+Observer RPC
> clogging.png, ShortTerm-Routers+Observer.png
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Changes will need to occur to the router to support the new observer node.
> One such change will be to make the router understand the observer state,
> e.g. {{FederationNamenodeServiceState}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
