[ https://issues.apache.org/jira/browse/HDFS-14478?focusedWorklogId=756171&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756171 ]
ASF GitHub Bot logged work on HDFS-14478: ----------------------------------------- Author: ASF GitHub Bot Created on: 13/Apr/22 04:30 Start Date: 13/Apr/22 04:30 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4166: URL: https://github.com/apache/hadoop/pull/4166#issuecomment-1097544133 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 15m 45s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 4 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 32m 28s | | trunk passed | | +1 :green_heart: | compile | 3m 32s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 21s | | trunk passed | | +1 :green_heart: | shadedclient | 67m 28s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 14s | | the patch passed | | +1 :green_heart: | compile | 3m 27s | | the patch passed | | +1 :green_heart: | cc | 3m 27s | | the patch passed | | +1 :green_heart: | golang | 3m 27s | | the patch passed | | +1 :green_heart: | javac | 3m 27s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | mvnsite | 0m 16s | | the patch passed | | +1 :green_heart: | shadedclient | 31m 11s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 92m 27s | | hadoop-hdfs-native-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 30s | | The patch does not generate ASF License warnings. | | | | 213m 41s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4166/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4166 | | Optional Tests | dupname asflicense compile cc mvnsite javac unit codespell golang | | uname | Linux 10f36a3ff98f 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 0d383e5698f449c0fa1fd6c4abeb3b2ad136eb38 | | Default Java | Debian-11.0.14+9-post-Debian-1deb10u1 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4166/1/testReport/ | | Max. process+thread count | 536 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4166/1/console | | versions | git=2.20.1 maven=3.6.0 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. Issue Time Tracking ------------------- Worklog Id: (was: 756171) Time Spent: 1h 40m (was: 1.5h) > Add libhdfs APIs for openFile > ----------------------------- > > Key: HDFS-14478 > URL: https://issues.apache.org/jira/browse/HDFS-14478 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client, libhdfs, native > Reporter: Sahil Takiar > Assignee: Steve Loughran > Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > HADOOP-15229 added a "FileSystem builder-based openFile() API" that allows > specifying configuration values for opening files (similar to HADOOP-14365). > Support for {{openFile}} will be a little tricky as it is asynchronous and > {{FutureDataInputStreamBuilder#build}} returns a {{CompletableFuture}}. > At a high level, the API for {{openFile}} could look something like this: > {code:java} > hdfsFile hdfsOpenFile(hdfsFS fs, const char* path, int flags, > int bufferSize, short replication, tSize blocksize); > hdfsOpenFileBuilder *hdfsOpenFileBuilderAlloc(hdfsFS fs, > const char *path); > hdfsOpenFileBuilder *hdfsOpenFileBuilderMust(hdfsOpenFileBuilder *builder, > const char *key, const char *value); > hdfsOpenFileBuilder *hdfsOpenFileBuilderOpt(hdfsOpenFileBuilder *builder, > const char *key, const char *value); > hdfsOpenFileFuture *hdfsOpenFileBuilderBuild(hdfsOpenFileBuilder *builder); > void hdfsOpenFileBuilderFree(hdfsOpenFileBuilder *builder); > hdfsFile hdfsOpenFileFutureGet(hdfsOpenFileFuture *future); > hdfsFile hdfsOpenFileFutureGetWithTimeout(hdfsOpenFileFuture *future, > int64_t timeout, javaConcurrentTimeUnit timeUnit); > int hdfsOpenFileFutureCancel(hdfsOpenFileFuture *future, > int mayInterruptIfRunning); > void hdfsOpenFileFutureFree(hdfsOpenFileFuture *future); > {code} > Instead of exposing all the functionality of {{CompleteableFuture}} libhdfs > would just expose the functionality of {{Future}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org