[
https://issues.apache.org/jira/browse/HDFS-16564?focusedWorklogId=763798&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763798
]
ASF GitHub Bot logged work on HDFS-16564:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/22 18:36
Start Date: 28/Apr/22 18:36
Worklog Time Spent: 10m
Work Description: goiri commented on code in PR #4245:
URL: https://github.com/apache/hadoop/pull/4245#discussion_r861205984
##########
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/hdfspp_mini_dfs_smoke.cc:
##########
@@ -34,7 +34,6 @@ TEST_F(HdfsMiniDfsSmokeTest, SmokeTest) {
EXPECT_NE(nullptr, connection.handle());
}
-
Review Comment:
Avoid
Issue Time Tracking
-------------------
Worklog Id: (was: 763798)
Time Spent: 20m (was: 10m)
> Use uint32_t for hdfs_find
> --------------------------
>
> Key: HDFS-16564
> URL: https://issues.apache.org/jira/browse/HDFS-16564
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs++
> Affects Versions: 3.4.0
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: libhdfscpp, pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> *hdfs_find* uses *u_int32_t* type for storing the value for the *max-depth*
> command line argument -
> https://github.com/apache/hadoop/blob/a631f45a99c7abf8c9a2dcfb10afb668c8ff6b09/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tools/hdfs-find/hdfs-find.cc#L43.
> The type u_int32_t isn't standard, isn't available on Windows and thus breaks
> cross-platform compatibility. We need to replace this with *uint32_t* which
> is available on all platforms since it's part of the C++ standard.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
