[ https://issues.apache.org/jira/browse/HDFS-16557?focusedWorklogId=764592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764592 ]
ASF GitHub Bot logged work on HDFS-16557: ----------------------------------------- Author: ASF GitHub Bot Created on: 30/Apr/22 02:24 Start Date: 30/Apr/22 02:24 Worklog Time Spent: 10m Work Description: tomscut commented on code in PR #4219: URL: https://github.com/apache/hadoop/pull/4219#discussion_r862281008 ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java: ########## @@ -1792,7 +1792,7 @@ private void checkForGaps(List<EditLogInputStream> streams, long fromTxId, EditLogInputStream elis = iter.next(); if (elis.getFirstTxId() > txId) break; long next = elis.getLastTxId(); Review Comment: Thanks @xkrogen for you suggestion. Issue Time Tracking ------------------- Worklog Id: (was: 764592) Time Spent: 1h 20m (was: 1h 10m) > BootstrapStandby failed because of checking gap for inprogress > EditLogInputStream > --------------------------------------------------------------------------------- > > Key: HDFS-16557 > URL: https://issues.apache.org/jira/browse/HDFS-16557 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Tao Li > Assignee: Tao Li > Priority: Major > Labels: pull-request-available > Attachments: image-2022-04-22-17-17-14-577.png, > image-2022-04-22-17-17-14-618.png, image-2022-04-22-17-17-23-113.png, > image-2022-04-22-17-17-32-487.png > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The lastTxId of an inprogress EditLogInputStream lastTxId isn't necessarily > HdfsServerConstants.INVALID_TXID. We can determine its status directly by > EditLogInputStream#isInProgress. > We introduced [SBN READ], and set > {color:#ff0000}{{dfs.ha.tail-edits.in-progress=true}}{color}. Then > bootstrapStandby, the EditLogInputStream of inProgress is misjudged, > resulting in a gap check failure, which causes bootstrapStandby to fail. > hdfs namenode -bootstrapStandby > !image-2022-04-22-17-17-32-487.png|width=766,height=161! > !image-2022-04-22-17-17-14-577.png|width=598,height=187! -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org