[ https://issues.apache.org/jira/browse/HDFS-16564?focusedWorklogId=764690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764690 ]
ASF GitHub Bot logged work on HDFS-16564: ----------------------------------------- Author: ASF GitHub Bot Created on: 30/Apr/22 17:47 Start Date: 30/Apr/22 17:47 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4245: URL: https://github.com/apache/hadoop/pull/4245#issuecomment-1114026936 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 39s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 26m 5s | | trunk passed | | +1 :green_heart: | compile | 3m 39s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 43s | | trunk passed | | -1 :x: | shadedclient | 56m 12s | | branch has errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 24s | | the patch passed | | +1 :green_heart: | compile | 3m 20s | | the patch passed | | +1 :green_heart: | cc | 3m 20s | | the patch passed | | +1 :green_heart: | golang | 3m 20s | | the patch passed | | +1 :green_heart: | javac | 3m 20s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | mvnsite | 0m 27s | | the patch passed | | -1 :x: | shadedclient | 25m 47s | | patch has errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 32m 42s | | hadoop-hdfs-native-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 47s | | The patch does not generate ASF License warnings. | | | | 122m 43s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4245/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4245 | | Optional Tests | dupname asflicense compile cc mvnsite javac unit codespell golang | | uname | Linux 82575fc92580 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 63293bbba9c00a2956b56466fd5e637cfd5a3631 | | Default Java | Debian-11.0.14+9-post-Debian-1deb10u1 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4245/3/testReport/ | | Max. process+thread count | 441 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4245/3/console | | versions | git=2.20.1 maven=3.6.0 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. Issue Time Tracking ------------------- Worklog Id: (was: 764690) Time Spent: 2.5h (was: 2h 20m) > Use uint32_t for hdfs_find > -------------------------- > > Key: HDFS-16564 > URL: https://issues.apache.org/jira/browse/HDFS-16564 > Project: Hadoop HDFS > Issue Type: Bug > Components: libhdfs++ > Affects Versions: 3.4.0 > Reporter: Gautham Banasandra > Assignee: Gautham Banasandra > Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 2.5h > Remaining Estimate: 0h > > *hdfs_find* uses *u_int32_t* type for storing the value for the *max-depth* > command line argument - > https://github.com/apache/hadoop/blob/a631f45a99c7abf8c9a2dcfb10afb668c8ff6b09/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tools/hdfs-find/hdfs-find.cc#L43. > The type u_int32_t isn't standard, isn't available on Windows and thus breaks > cross-platform compatibility. We need to replace this with *uint32_t* which > is available on all platforms since it's part of the C++ standard. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org