[ https://issues.apache.org/jira/browse/HDFS-16561?focusedWorklogId=774927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774927 ]
ASF GitHub Bot logged work on HDFS-16561: ----------------------------------------- Author: ASF GitHub Bot Created on: 26/May/22 07:52 Start Date: 26/May/22 07:52 Worklog Time Spent: 10m Work Description: rishabh1704 commented on PR #4287: URL: https://github.com/apache/hadoop/pull/4287#issuecomment-1138265747 > Congratulations on your first PR @rishabh1704 ๐Welcome to the Hadoop community ๐ Thanks a lot @GauthamBanasandra for mentoring. Looking forward to more of these!๐ Issue Time Tracking ------------------- Worklog Id: (was: 774927) Time Spent: 3h 10m (was: 3h) > Handle error returned by strtol > ------------------------------- > > Key: HDFS-16561 > URL: https://issues.apache.org/jira/browse/HDFS-16561 > Project: Hadoop HDFS > Issue Type: Bug > Components: libhdfs++ > Affects Versions: 3.4.0 > Reporter: Gautham Banasandra > Assignee: Gautham Banasandra > Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > *strtol* is used in > [hdfs-chmod.cc|https://github.com/apache/hadoop/blob/6dddbd42edd57cc26279c678756386a47c040af5/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tools/hdfs-chmod/hdfs-chmod.cc#L144]. > The call to strtol could error out when an invalid input is provided. Need > to handle the error given out by strtol. > Tasks to do - > 1. Detect the error returned by strtol. The [strtol documentation > |https://en.cppreference.com/w/cpp/string/byte/strtol]explains how to do so. > 2. Return false to the caller if the error is detected. > 3. Extend > [this|https://github.com/apache/hadoop/blob/6dddbd42edd57cc26279c678756386a47c040af5/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/tools/hdfs-chmod-mock.cc] > unit test and add a case which exercises this by passing an invalid input. > Please refer to this PR to get more context on how this unit test is written > - https://github.com/apache/hadoop/pull/3588. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org