[ 
https://issues.apache.org/jira/browse/HDFS-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190668#comment-13190668
 ] 

Devaraj K commented on HDFS-2818:
---------------------------------

\\
{code:xml}
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
 Please justify why no new tests are needed for this patch.
 Also please list what manual steps were performed to verify this patch.
{code}

It is trivial jsp change, doesn't need tests.
\\

{code:xml}
-1 javadoc. The javadoc tool appears to have generated 21 warning messages.
{code}

{code:xml}
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) 
warnings.
{code}

These are not related to this patch.
                
> dfshealth.jsp missing space between role and node name
> ------------------------------------------------------
>
>                 Key: HDFS-2818
>                 URL: https://issues.apache.org/jira/browse/HDFS-2818
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Priority: Trivial
>              Labels: newbie
>         Attachments: HDFS-2818.patch
>
>
> There seems to be a missing space in the titles of our webpages. EG: 
> <title>Hadoop NameNodestyx01.sf.cloudera.com:8021</title>. It seems like the 
> JSP compiler is doing something to the space which is in the .jsp. Probably a 
> simple fix if you know something about JSP :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to