[ https://issues.apache.org/jira/browse/HDFS-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
fanshilun updated HDFS-16603: ----------------------------- Description: When reading the code, I found that some usage methods are outdated due to the upgrade of netty components. {color:#172b4d}*1.DatanodeHttpServer#Constructor*{color} {code:java} @Deprecated public static final ChannelOption<Integer> WRITE_BUFFER_HIGH_WATER_MARK = valueOf("WRITE_BUFFER_HIGH_WATER_MARK"); Deprecated. Use WRITE_BUFFER_WATER_MARK @Deprecated public static final ChannelOption<Integer> WRITE_BUFFER_LOW_WATER_MARK = valueOf("WRITE_BUFFER_LOW_WATER_MARK"); Deprecated. Use WRITE_BUFFER_WATER_MARK ----- this.httpServer.childOption( ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK, conf.getInt( DFSConfigKeys.DFS_WEBHDFS_NETTY_HIGH_WATERMARK, DFSConfigKeys.DFS_WEBHDFS_NETTY_HIGH_WATERMARK_DEFAULT)); this.httpServer.childOption( ChannelOption.WRITE_BUFFER_LOW_WATER_MARK, conf.getInt( DFSConfigKeys.DFS_WEBHDFS_NETTY_LOW_WATERMARK, DFSConfigKeys.DFS_WEBHDFS_NETTY_LOW_WATERMARK_DEFAULT)); {code} *2.Duplicate code* {code:java} ChannelFuture f = httpServer.bind(infoAddr); try { f.syncUninterruptibly(); } catch (Throwable e) { if (e instanceof BindException) { throw NetUtils.wrapException(null, 0, infoAddr.getHostName(), infoAddr.getPort(), (SocketException) e); } else { throw e; } } httpAddress = (InetSocketAddress) f.channel().localAddress(); LOG.info("Listening HTTP traffic on " + httpAddress);{code} *3.io.netty.bootstrap.ChannelFactory Deprecated* {code:java} /** @deprecated */ @Deprecated public interface ChannelFactory<T extends Channel> { T newChannel(); }{code} was: When reading the code, I found that some usage methods are outdated due to the upgrade of netty components. {color:#172b4d}*1.DatanodeHttpServer#Constructor*{color} {code:java} @Deprecated public static final ChannelOption<Integer> WRITE_BUFFER_HIGH_WATER_MARK = valueOf("WRITE_BUFFER_HIGH_WATER_MARK"); Deprecated. Use WRITE_BUFFER_WATER_MARK @Deprecated public static final ChannelOption<Integer> WRITE_BUFFER_LOW_WATER_MARK = valueOf("WRITE_BUFFER_LOW_WATER_MARK"); Deprecated. Use WRITE_BUFFER_WATER_MARK ----- this.httpServer.childOption( ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK, conf.getInt( DFSConfigKeys.DFS_WEBHDFS_NETTY_HIGH_WATERMARK, DFSConfigKeys.DFS_WEBHDFS_NETTY_HIGH_WATERMARK_DEFAULT)); this.httpServer.childOption( ChannelOption.WRITE_BUFFER_LOW_WATER_MARK, conf.getInt( DFSConfigKeys.DFS_WEBHDFS_NETTY_LOW_WATERMARK, DFSConfigKeys.DFS_WEBHDFS_NETTY_LOW_WATERMARK_DEFAULT)); {code} *2.Duplicate code* {code:java} ChannelFuture f = httpServer.bind(infoAddr); try { f.syncUninterruptibly(); } catch (Throwable e) { if (e instanceof BindException) { throw NetUtils.wrapException(null, 0, infoAddr.getHostName(), infoAddr.getPort(), (SocketException) e); } else { throw e; } } httpAddress = (InetSocketAddress) f.channel().localAddress(); {code} > Improve DatanodeHttpServer With Netty recommended method > -------------------------------------------------------- > > Key: HDFS-16603 > URL: https://issues.apache.org/jira/browse/HDFS-16603 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: fanshilun > Assignee: fanshilun > Priority: Minor > Fix For: 3.4.0 > > > When reading the code, I found that some usage methods are outdated due to > the upgrade of netty components. > {color:#172b4d}*1.DatanodeHttpServer#Constructor*{color} > {code:java} > @Deprecated > public static final ChannelOption<Integer> WRITE_BUFFER_HIGH_WATER_MARK = > valueOf("WRITE_BUFFER_HIGH_WATER_MARK"); > Deprecated. Use WRITE_BUFFER_WATER_MARK > @Deprecated > public static final ChannelOption<Integer> WRITE_BUFFER_LOW_WATER_MARK = > valueOf("WRITE_BUFFER_LOW_WATER_MARK"); > Deprecated. Use WRITE_BUFFER_WATER_MARK > ----- > this.httpServer.childOption( > ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK, > conf.getInt( > DFSConfigKeys.DFS_WEBHDFS_NETTY_HIGH_WATERMARK, > DFSConfigKeys.DFS_WEBHDFS_NETTY_HIGH_WATERMARK_DEFAULT)); > this.httpServer.childOption( > ChannelOption.WRITE_BUFFER_LOW_WATER_MARK, > conf.getInt( > DFSConfigKeys.DFS_WEBHDFS_NETTY_LOW_WATERMARK, > DFSConfigKeys.DFS_WEBHDFS_NETTY_LOW_WATERMARK_DEFAULT)); > {code} > *2.Duplicate code* > {code:java} > ChannelFuture f = httpServer.bind(infoAddr); > try { > f.syncUninterruptibly(); > } catch (Throwable e) { > if (e instanceof BindException) { > throw NetUtils.wrapException(null, 0, infoAddr.getHostName(), > infoAddr.getPort(), (SocketException) e); > } else { > throw e; > } > } > httpAddress = (InetSocketAddress) f.channel().localAddress(); > LOG.info("Listening HTTP traffic on " + httpAddress);{code} > *3.io.netty.bootstrap.ChannelFactory Deprecated* > {code:java} > /** @deprecated */ > @Deprecated > public interface ChannelFactory<T extends Channel> { > T newChannel(); > }{code} -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org