[ 
https://issues.apache.org/jira/browse/HDFS-16610?focusedWorklogId=776379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776379
 ]

ASF GitHub Bot logged work on HDFS-16610:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/May/22 14:56
            Start Date: 31/May/22 14:56
    Worklog Time Spent: 10m 
      Work Description: sodonnel commented on code in PR #4384:
URL: https://github.com/apache/hadoop/pull/4384#discussion_r885745283


##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java:
##########
@@ -273,6 +273,14 @@ public interface HdfsClientConfigKeys {
   String DFS_LEASE_HARDLIMIT_KEY = "dfs.namenode.lease-hard-limit-sec";
   long DFS_LEASE_HARDLIMIT_DEFAULT = 20 * 60;
 
+  String DFS_CLIENT_FSCK_CONNECT_TIMEOUT_MS =
+      "dfs.client.fsck.connect.timeout.ms";
+  int DFS_CLIENT_FSCK_CONNECT_TIMEOUT_MS_DEFAULT = 60 * 1000;
+
+  String DFS_CLIENT_FSCK_READ_TIMEOUT_MS =
+      "dfs.client.fsck.read.timeout.ms";
+  int DFS_CLIENT_FSCK_READ_TIMEOUT_MS_DEFAULT = 60 * 1000;

Review Comment:
   This suggestion makes sense. I have changed it to use the same technique as 
with webhdfs.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 776379)
    Time Spent: 0.5h  (was: 20m)

> Make fsck read timeout configurable
> -----------------------------------
>
>                 Key: HDFS-16610
>                 URL: https://issues.apache.org/jira/browse/HDFS-16610
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>            Reporter: Stephen O'Donnell
>            Assignee: Stephen O'Donnell
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In a cluster with a lot of small files, we encountered a case where fsck was 
> very slow. I believe it is due to contention with many other threads reading 
> / writing data on the cluster.
> Sometimes fsck does not report any progress for more than 60 seconds and the 
> client times out. Currently the connect and read timeout are hardcoded to 60 
> seconds. This change is to make them configurable.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to