[
https://issues.apache.org/jira/browse/HDFS-16618?focusedWorklogId=778480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778480
]
ASF GitHub Bot logged work on HDFS-16618:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/22 00:58
Start Date: 06/Jun/22 00:58
Worklog Time Spent: 10m
Work Description: tomscut commented on code in PR #4402:
URL: https://github.com/apache/hadoop/pull/4402#discussion_r889762386
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetAsyncDiskService.java:
##########
@@ -216,16 +216,20 @@ synchronized void shutdown() {
}
}
- public void submitSyncFileRangeRequest(FsVolumeImpl volume,
- final ReplicaOutputStreams streams, final long offset, final long nbytes,
- final int flags) {
- execute(volume, new Runnable() {
- @Override
- public void run() {
+ public void submitSyncFileRangeRequest(FsVolumeImpl volume, final
ReplicaOutputStreams streams,
+ final long offset, final long nbytes, final int flags) {
+ execute(volume, () -> {
+ try {
+ streams.syncFileRangeIfPossible(offset, nbytes, flags);
+ } catch (NativeIOException e) {
try {
- streams.syncFileRangeIfPossible(offset, nbytes, flags);
- } catch (NativeIOException e) {
- LOG.warn("sync_file_range error", e);
+ LOG.warn("sync_file_range error. Volume: {} , Capacity: {},
Available space: {}, "
Review Comment:
Hi @virajjasani , please remove this extra space.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetAsyncDiskService.java:
##########
@@ -216,16 +216,20 @@ synchronized void shutdown() {
}
}
- public void submitSyncFileRangeRequest(FsVolumeImpl volume,
- final ReplicaOutputStreams streams, final long offset, final long nbytes,
- final int flags) {
- execute(volume, new Runnable() {
- @Override
- public void run() {
+ public void submitSyncFileRangeRequest(FsVolumeImpl volume, final
ReplicaOutputStreams streams,
+ final long offset, final long nbytes, final int flags) {
+ execute(volume, () -> {
+ try {
+ streams.syncFileRangeIfPossible(offset, nbytes, flags);
+ } catch (NativeIOException e) {
try {
- streams.syncFileRangeIfPossible(offset, nbytes, flags);
- } catch (NativeIOException e) {
- LOG.warn("sync_file_range error", e);
+ LOG.warn("sync_file_range error. Volume: {} , Capacity: {},
Available space: {}, "
Review Comment:
```suggestion
LOG.warn("sync_file_range error. Volume: {}, Capacity: {},
Available space: {}, "
```
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetAsyncDiskService.java:
##########
@@ -216,16 +216,20 @@ synchronized void shutdown() {
}
}
- public void submitSyncFileRangeRequest(FsVolumeImpl volume,
- final ReplicaOutputStreams streams, final long offset, final long nbytes,
- final int flags) {
- execute(volume, new Runnable() {
- @Override
- public void run() {
+ public void submitSyncFileRangeRequest(FsVolumeImpl volume, final
ReplicaOutputStreams streams,
+ final long offset, final long nbytes, final int flags) {
+ execute(volume, () -> {
+ try {
+ streams.syncFileRangeIfPossible(offset, nbytes, flags);
+ } catch (NativeIOException e) {
try {
- streams.syncFileRangeIfPossible(offset, nbytes, flags);
- } catch (NativeIOException e) {
- LOG.warn("sync_file_range error", e);
+ LOG.warn("sync_file_range error. Volume: {} , Capacity: {},
Available space: {}, "
+ + "File range offset: {}, length: {}, flags: {}", volume,
volume.getCapacity(),
+ volume.getAvailable(), offset, nbytes, flags, e);
+ } catch (IOException ioe) {
+ LOG.warn("sync_file_range error. Volume: {} , Capacity: {}, "
Review Comment:
```suggestion
LOG.warn("sync_file_range error. Volume: {}, Capacity: {}, "
```
Issue Time Tracking
-------------------
Worklog Id: (was: 778480)
Time Spent: 40m (was: 0.5h)
> sync_file_range error should include more volume and file info
> --------------------------------------------------------------
>
> Key: HDFS-16618
> URL: https://issues.apache.org/jira/browse/HDFS-16618
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Having seen multiple sync_file_range errors recently with Bad file
> descriptor, it would be good to include more volume stats as well as file
> offset/length info with the error log to get some more insights.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
