[ https://issues.apache.org/jira/browse/HDFS-16609?focusedWorklogId=778811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778811 ]
ASF GitHub Bot logged work on HDFS-16609: ----------------------------------------- Author: ASF GitHub Bot Created on: 07/Jun/22 01:32 Start Date: 07/Jun/22 01:32 Worklog Time Spent: 10m Work Description: tomscut commented on code in PR #4382: URL: https://github.com/apache/hadoop/pull/4382#discussion_r890688840 ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java: ########## @@ -282,7 +282,7 @@ public void testServerDefaultsWithMinimalCaching() throws Exception { // do nothing; return false; } - }, 1, 3000); + }, 1, 6000); Review Comment: The comment `Wait for 3 seconds` above also needs to be changed. Issue Time Tracking ------------------- Worklog Id: (was: 778811) Time Spent: 50m (was: 40m) > Fix Flakes Junit Tests that often report timeouts > ------------------------------------------------- > > Key: HDFS-16609 > URL: https://issues.apache.org/jira/browse/HDFS-16609 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: fanshilun > Assignee: fanshilun > Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 50m > Remaining Estimate: 0h > > When I was dealing with HDFS-16590 JIRA, Junit Tests often reported errors, I > found that one type of problem is TimeOut problem, these problems can be > avoided by adjusting TimeOut time. > The modified method is as follows: > 1.org.apache.hadoop.hdfs.TestFileCreation#testServerDefaultsWithMinimalCaching > {code:java} > [ERROR] > testServerDefaultsWithMinimalCaching(org.apache.hadoop.hdfs.TestFileCreation) > Time elapsed: 7.136 s <<< ERROR! > java.util.concurrent.TimeoutException: > Timed out waiting for condition. > Thread diagnostics: > [WARNING] > org.apache.hadoop.hdfs.TestFileCreation.testServerDefaultsWithMinimalCaching(org.apache.hadoop.hdfs.TestFileCreation) > [ERROR] Run 1: TestFileCreation.testServerDefaultsWithMinimalCaching:277 > Timeout Timed out ... > [INFO] Run 2: PASS{code} > 2.org.apache.hadoop.hdfs.TestDFSShell#testFilePermissions > {code:java} > [ERROR] testFilePermissions(org.apache.hadoop.hdfs.TestDFSShell) Time > elapsed: 30.022 s <<< ERROR! > org.junit.runners.model.TestTimedOutException: test timed out after 30000 > milliseconds > at java.lang.Thread.dumpThreads(Native Method) > at java.lang.Thread.getStackTrace(Thread.java:1549) > at > org.junit.internal.runners.statements.FailOnTimeout.createTimeoutException(FailOnTimeout.java:182) > at > org.junit.internal.runners.statements.FailOnTimeout.getResult(FailOnTimeout.java:177) > at > org.junit.internal.runners.statements.FailOnTimeout.evaluate(FailOnTimeout.java:128) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.lang.Thread.run(Thread.java:748) > [WARNING] > org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(org.apache.hadoop.hdfs.TestDFSShell) > [ERROR] Run 1: TestDFSShell.testFilePermissions TestTimedOut test timed out > after 30000 mil... > [INFO] Run 2: PASS {code} > 3.org.apache.hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier#testSPSWhenFileHasExcessRedundancyBlocks > {code:java} > [ERROR] > testSPSWhenFileHasExcessRedundancyBlocks(org.apache.hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier) > Time elapsed: 67.904 s <<< ERROR! > java.util.concurrent.TimeoutException: > Timed out waiting for condition. > [WARNING] > org.apache.hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier.testSPSWhenFileHasExcessRedundancyBlocks(org.apache.hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier) > [ERROR] Run 1: > TestExternalStoragePolicySatisfier.testSPSWhenFileHasExcessRedundancyBlocks:1379 > Timeout > [ERROR] Run 2: > TestExternalStoragePolicySatisfier.testSPSWhenFileHasExcessRedundancyBlocks:1379 > Timeout > [INFO] Run 3: PASS {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org