[ https://issues.apache.org/jira/browse/HDFS-16463?focusedWorklogId=778994&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778994 ]
ASF GitHub Bot logged work on HDFS-16463: ----------------------------------------- Author: ASF GitHub Bot Created on: 07/Jun/22 11:12 Start Date: 07/Jun/22 11:12 Worklog Time Spent: 10m Work Description: GauthamBanasandra commented on code in PR #4370: URL: https://github.com/apache/hadoop/pull/4370#discussion_r891085844 ########## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/x-platform/c-api/dirent.cc: ########## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <algorithm> +#include <cerrno> +#include <iostream> +#include <iterator> +#include <system_error> +#include <variant> + +#include "x-platform/c-api/dirent.h" +#include "x-platform/dirent.h" + +#if defined(WIN32) && defined(__cplusplus) Review Comment: I've put the `extern "C"` in the `c-api/dirent.h` header file. I thought that I had to enclose the implementation as well. I just removed the `extern "C"` enclosure in the implementation and I was able to build fine on both Windows and Ubuntu. I ran the tests on both the platforms and they're working fine - ## Windows 10 ![image](https://user-images.githubusercontent.com/10280768/172365616-57f1b051-e010-4f18-bc99-344cfb1496af.png) ## Ubuntu Focal ![image](https://user-images.githubusercontent.com/10280768/172365730-df247cb8-8e7b-44f3-b094-a22dffa76d53.png) I've removed the `extern "C"` enclosure from the implementation now, since it's redundant. Issue Time Tracking ------------------- Worklog Id: (was: 778994) Time Spent: 4h 50m (was: 4h 40m) > Make dirent cross platform compatible > ------------------------------------- > > Key: HDFS-16463 > URL: https://issues.apache.org/jira/browse/HDFS-16463 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs++ > Affects Versions: 3.4.0 > Environment: Windows 10 > Reporter: Gautham Banasandra > Assignee: Gautham Banasandra > Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 4h 50m > Remaining Estimate: 0h > > [jnihelper.c|https://github.com/apache/hadoop/blob/1fed18bb2d8ac3dbaecc3feddded30bed918d556/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/jni_helper.c#L28] > in HDFS native client uses *dirent.h*. This header file isn't available on > Windows. Thus, we need to replace this with a cross platform compatible > implementation for dirent. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org