[ https://issues.apache.org/jira/browse/HDFS-13522?focusedWorklogId=781545&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781545 ]
ASF GitHub Bot logged work on HDFS-13522: ----------------------------------------- Author: ASF GitHub Bot Created on: 15/Jun/22 09:01 Start Date: 15/Jun/22 09:01 Worklog Time Spent: 10m Work Description: zhengchenyu commented on PR #4441: URL: https://github.com/apache/hadoop/pull/4441#issuecomment-1156196587 > Thanks @zhengchenyu for your review and comment. This a draft PR related to [PR4311](https://github.com/apache/hadoop/pull/4311). I'm not following [HDFS-13522](https://issues.apache.org/jira/browse/HDFS-13522).002.patch, and I will read it carefully. > > Client -> RBF -> NameNode. Whether RBF proxies the read request to the Observer should have nothing to do with the Client. In HDFS-13522.002.patch, isReadCall method, router will check "call.getClientStateId() == -1L". This is rpc call level. If observer read is disable in client side, call.getClientStateId() in router side will return -1, router will ignore observer namenode. I think config in client side may be more flexible. By the way, I add some extra comment. In HDFS-13522.002.patch, router only check whether state id is -1. They don't pass client's state id. If dfs.federation.router.observer.auto-msync-period are not set to 0, but a large number, will be wrong. In our draft design, after apply HDFS-13522.002.patch, I wanna proxy client's state id. For busy work recently, I delay it. Maybe we can work and discuss it together. Issue Time Tracking ------------------- Worklog Id: (was: 781545) Time Spent: 12h 10m (was: 12h) > RBF: Support observer node from Router-Based Federation > ------------------------------------------------------- > > Key: HDFS-13522 > URL: https://issues.apache.org/jira/browse/HDFS-13522 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: federation, namenode > Reporter: Erik Krogen > Assignee: Simbarashe Dzinamarira > Priority: Major > Labels: pull-request-available > Attachments: HDFS-13522.001.patch, HDFS-13522.002.patch, > HDFS-13522_WIP.patch, RBF_ Observer support.pdf, Router+Observer RPC > clogging.png, ShortTerm-Routers+Observer.png > > Time Spent: 12h 10m > Remaining Estimate: 0h > > Changes will need to occur to the router to support the new observer node. > One such change will be to make the router understand the observer state, > e.g. {{FederationNamenodeServiceState}}. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org