[ https://issues.apache.org/jira/browse/HDFS-16283?focusedWorklogId=788490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-788490 ]
ASF GitHub Bot logged work on HDFS-16283: ----------------------------------------- Author: ASF GitHub Bot Created on: 07/Jul/22 06:02 Start Date: 07/Jul/22 06:02 Worklog Time Spent: 10m Work Description: ayushtkn commented on code in PR #4524: URL: https://github.com/apache/hadoop/pull/4524#discussion_r915487803 ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java: ########## @@ -1174,8 +1174,16 @@ public boolean mkdirs(String src, FsPermission masked, boolean createParent) } @Override // ClientProtocol - public void renewLease(String clientName) throws IOException { + public void renewLease(String clientName, List<String> namespaces) + throws IOException { + if (namespaces != null && namespaces.size() > 0) { + LOG.warn("namespaces({}) should be null or empty " + + "on NameNode side, please check it.", namespaces); + throw new IOException("namespaces(" + namespaces + + ") should be null or empty"); + } checkNNStartup(); + // just ignore nsIdentifies Review Comment: remove this line or change it to // Ignore the namespaces. Issue Time Tracking ------------------- Worklog Id: (was: 788490) Time Spent: 5.5h (was: 5h 20m) > RBF: improve renewLease() to call only a specific NameNode rather than make > fan-out calls > ----------------------------------------------------------------------------------------- > > Key: HDFS-16283 > URL: https://issues.apache.org/jira/browse/HDFS-16283 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: rbf > Reporter: Aihua Xu > Assignee: Aihua Xu > Priority: Major > Labels: pull-request-available > Attachments: RBF_ improve renewLease() to call only a specific > NameNode rather than make fan-out calls.pdf > > Time Spent: 5.5h > Remaining Estimate: 0h > > Currently renewLease() against a router will make fan-out to all the > NameNodes. Since renewLease() call is so frequent and if one of the NameNodes > are slow, then eventually the router queues are blocked by all renewLease() > and cause router degradation. > We will make a change in the client side to keep track of NameNode Id in > additional to current fileId so routers understand which NameNodes the client > is renewing lease against. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org