[ https://issues.apache.org/jira/browse/HDFS-16464?focusedWorklogId=791723&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-791723 ]
ASF GitHub Bot logged work on HDFS-16464: ----------------------------------------- Author: ASF GitHub Bot Created on: 17/Jul/22 07:57 Start Date: 17/Jul/22 07:57 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4571: URL: https://github.com/apache/hadoop/pull/4571#issuecomment-1186435539 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 44s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 40m 3s | | trunk passed | | +1 :green_heart: | compile | 4m 11s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 45s | | trunk passed | | +1 :green_heart: | shadedclient | 65m 33s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 22s | | the patch passed | | +1 :green_heart: | compile | 3m 31s | | the patch passed | | +1 :green_heart: | cc | 3m 31s | | the patch passed | | +1 :green_heart: | golang | 3m 31s | | the patch passed | | +1 :green_heart: | javac | 3m 31s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | mvnsite | 0m 27s | | the patch passed | | +1 :green_heart: | shadedclient | 19m 6s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 36m 19s | | hadoop-hdfs-native-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 53s | | The patch does not generate ASF License warnings. | | | | 129m 21s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4571/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4571 | | Optional Tests | dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang | | uname | Linux e4ee9e2b0bc6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 9dc5cd0d060ed87bdbc9b20e7bf6d4a90578bf68 | | Default Java | Red Hat, Inc.-1.8.0_332-b09 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4571/2/testReport/ | | Max. process+thread count | 704 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4571/2/console | | versions | git=2.9.5 maven=3.6.3 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. Issue Time Tracking ------------------- Worklog Id: (was: 791723) Time Spent: 0.5h (was: 20m) > Create only libhdfspp static libraries for Windows > -------------------------------------------------- > > Key: HDFS-16464 > URL: https://issues.apache.org/jira/browse/HDFS-16464 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs++ > Affects Versions: 3.4.0 > Environment: Windows 10 > Reporter: Gautham Banasandra > Assignee: Gautham Banasandra > Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > While building dynamic libraries (.dll) on Windows, there's a constraint that > all the dependent libraries be linked dynamically. This poses an issue since > Protobuf (which is an HDFS native client dependency) runs into build issues > when linked dynamically. There are a few [warning > notes|https://github.com/protocolbuffers/protobuf/blob/9ebb31726cef11e4e940b50ec751df4e863e3d2a/cmake/README.md#dlls-vs-static-linking] > on the Protobuf repository's build instructions page as well. > Thus, to keep things simple, we can resort to do only static linking and > thereby only produce statically linked libraries on Windows. In summary, > we'll be providing only Hadoop .lib files initially. We can aim to produce > Hadoop .dll on Windows eventually once we're able to resolve Protobuf's .dll > issues. > In Hadoop CMake files, we've a function > [hadoop_add_dual_library|https://github.com/apache/hadoop/blob/f0241ec2161f6eccdb9bdaf1cbcbee55be379217/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt#L289-L298] > that creates both the static an dynamic library targets. We need to replace > all these to get only static libraries for Windows. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org