[ https://issues.apache.org/jira/browse/HDFS-16665?focusedWorklogId=791860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-791860 ]
ASF GitHub Bot logged work on HDFS-16665: ----------------------------------------- Author: ASF GitHub Bot Created on: 18/Jul/22 06:37 Start Date: 18/Jul/22 06:37 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4573: URL: https://github.com/apache/hadoop/pull/4573#issuecomment-1186821379 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 57s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 21m 27s | | trunk passed | | +1 :green_heart: | compile | 4m 4s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | compile | 4m 6s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | mvnsite | 0m 45s | | trunk passed | | +1 :green_heart: | shadedclient | 50m 8s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 24s | | the patch passed | | +1 :green_heart: | compile | 3m 43s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | cc | 3m 43s | | the patch passed | | +1 :green_heart: | javac | 3m 43s | | the patch passed | | +1 :green_heart: | compile | 3m 45s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | cc | 3m 45s | | the patch passed | | +1 :green_heart: | javac | 3m 45s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | mvnsite | 0m 27s | | the patch passed | | +1 :green_heart: | shadedclient | 19m 28s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 106m 28s | | hadoop-hdfs-native-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 45s | | The patch does not generate ASF License warnings. | | | | 188m 46s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4573/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4573 | | Optional Tests | dupname asflicense compile cc mvnsite javac unit codespell detsecrets | | uname | Linux 6e018b4716e2 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / cd9094d30f4fac727dbf556ff317270578ae4a1a | | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4573/1/testReport/ | | Max. process+thread count | 619 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4573/1/console | | versions | git=2.25.1 maven=3.6.3 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. Issue Time Tracking ------------------- Worklog Id: (was: 791860) Time Spent: 50m (was: 40m) > Fix duplicate sources for hdfspp_test_shim_static > ------------------------------------------------- > > Key: HDFS-16665 > URL: https://issues.apache.org/jira/browse/HDFS-16665 > Project: Hadoop HDFS > Issue Type: Bug > Components: libhdfs++ > Affects Versions: 3.4.0 > Environment: Windows 10 > Reporter: Gautham Banasandra > Assignee: Gautham Banasandra > Priority: Critical > Labels: libhdfscpp, pull-request-available > Attachments: hdfs_shim duplicate symbols.log > > Time Spent: 50m > Remaining Estimate: 0h > > The library target *hdfspp_test_shim_static* is built using the following > sources, which causes duplicate symbols to be defined - > 1. hdfs_shim.c > 2. ${LIBHDFSPP_BINDING_C}/hdfs.cc > https://github.com/apache/hadoop/blob/8774f178686487007dcf8c418c989b785a529000/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/CMakeLists.txt#L153 > And fails the compilation - > {code} > H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\out\build\x64-Debug\hdfspp_test_shim_static.lib(hdfs_shim.obj) > : error LNK2005: hdfsAllowSnapshot already defined in > hdfspp_test_shim_static.lib(hdfs.obj) > H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\out\build\x64-Debug\hdfspp_test_shim_static.lib(hdfs_shim.obj) > : error LNK2005: hdfsAvailable already defined in > hdfspp_test_shim_static.lib(hdfs.obj) > H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\out\build\x64-Debug\hdfspp_test_shim_static.lib(hdfs_shim.obj) > : error LNK2005: hdfsBuilderConfSetStr already defined in > hdfspp_test_shim_static.lib(hdfs.obj) > H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\out\build\x64-Debug\hdfspp_test_shim_static.lib(hdfs_shim.obj) > : error LNK2005: hdfsBuilderConnect already defined in > hdfspp_test_shim_static.lib(hdfs.obj) > {code} > Duplicate symbols defined by hdfs_shim.c - > https://github.com/apache/hadoop/blob/440f4c2b28515d2007b81ac00b549bbf14fa9f64/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/hdfs_shim.c#L583-L585. > Adding the source *${LIBHDFSPP_BINDING_C}/hdfs.cc* is redundant here since > this file is transitively included in hdfs_shim.c through > *libhdfspp_wrapper.h* - > https://github.com/apache/hadoop/blob/440f4c2b28515d2007b81ac00b549bbf14fa9f64/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/hdfs_shim.c#L20. > Thus, we need to exclude *${LIBHDFSPP_BINDING_C}/hdfs.cc* to fix this issue. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org