[ https://issues.apache.org/jira/browse/HDFS-16547?focusedWorklogId=792391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-792391 ]
ASF GitHub Bot logged work on HDFS-16547: ----------------------------------------- Author: ASF GitHub Bot Created on: 18/Jul/22 23:50 Start Date: 18/Jul/22 23:50 Worklog Time Spent: 10m Work Description: ZanderXu commented on code in PR #4201: URL: https://github.com/apache/hadoop/pull/4201#discussion_r923945338 ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java: ########## @@ -1899,6 +1899,9 @@ synchronized void transitionToStandby() throws IOException { synchronized void transitionToObserver() throws IOException { String operationName = "transitionToObserver"; namesystem.checkSuperuserPrivilege(operationName); + if (notBecomeActiveInSafemode && isInSafeMode()) { Review Comment: Can we use a common flag? `notBecomeActiveInSafemode` is used to control Active. Issue Time Tracking ------------------- Worklog Id: (was: 792391) Time Spent: 1h 50m (was: 1h 40m) > [SBN read] Namenode in safe mode should not be transfered to observer state > --------------------------------------------------------------------------- > > Key: HDFS-16547 > URL: https://issues.apache.org/jira/browse/HDFS-16547 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Tao Li > Assignee: Tao Li > Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > Currently, when a Namenode is in safemode(under starting or enter safemode > manually), we can transfer this Namenode to Observer by command. This > Observer node may receive many requests and then throw a SafemodeException, > this causes unnecessary failover on the client. > So Namenode in safe mode should not be transfer to observer state. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org