[ https://issues.apache.org/jira/browse/HDFS-16667?focusedWorklogId=792665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-792665 ]
ASF GitHub Bot logged work on HDFS-16667: ----------------------------------------- Author: ASF GitHub Bot Created on: 19/Jul/22 12:55 Start Date: 19/Jul/22 12:55 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4576: URL: https://github.com/apache/hadoop/pull/4576#issuecomment-1189018718 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 29m 12s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 27m 29s | | trunk passed | | +1 :green_heart: | compile | 4m 54s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 50s | | trunk passed | | +1 :green_heart: | shadedclient | 58m 16s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 26s | | the patch passed | | +1 :green_heart: | compile | 4m 12s | | the patch passed | | +1 :green_heart: | cc | 4m 12s | | the patch passed | | +1 :green_heart: | golang | 4m 12s | | the patch passed | | +1 :green_heart: | javac | 4m 12s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | mvnsite | 0m 27s | | the patch passed | | +1 :green_heart: | shadedclient | 23m 42s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 107m 12s | | hadoop-hdfs-native-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 49s | | The patch does not generate ASF License warnings. | | | | 227m 4s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4576/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4576 | | Optional Tests | dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang | | uname | Linux a10d05b9b421 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / df2323ca40fb4579c6be56bee9b8a780c20243d5 | | Default Java | Red Hat, Inc.-1.8.0_312-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4576/3/testReport/ | | Max. process+thread count | 623 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4576/3/console | | versions | git=2.27.0 maven=3.6.3 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. Issue Time Tracking ------------------- Worklog Id: (was: 792665) Time Spent: 1h (was: 50m) > Use malloc for buffer allocation in uriparser2 > ---------------------------------------------- > > Key: HDFS-16667 > URL: https://issues.apache.org/jira/browse/HDFS-16667 > Project: Hadoop HDFS > Issue Type: Bug > Components: libhdfs++ > Affects Versions: 3.4.0 > Environment: Windows 10 > Reporter: Gautham Banasandra > Assignee: Gautham Banasandra > Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Currently, a variable is used to specify the array size in *uriparser2* - > https://github.com/apache/hadoop/blob/34e548cb62ed21c5bba7a82f5f1489ca6bdfb8c4/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/third_party/uriparser2/uriparser2/uriparser2.c#L71-L79 > {code:cpp} > static int parse_int(const char *first, const char *after_last) { > const int size = after_last - first; > if (size) { > char buffer[size + 1]; > memcpyz(buffer, first, size); > return atoi(buffer); > } > return 0; > } > {code} > This results in the following error on Windows - > {code} > H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\out\build\x64-Debug\cl : > command line warning D9025: overriding '/W4' with '/w' > uriparser2.c > H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\main\native\libhdfspp\third_party\uriparser2\uriparser2\uriparser2.c(74,23): > error C2057: expected constant expression > H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\main\native\libhdfspp\third_party\uriparser2\uriparser2\uriparser2.c(74,23): > error C2466: cannot allocate an array of constant size 0 > H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\main\native\libhdfspp\third_party\uriparser2\uriparser2\uriparser2.c(74,24): > error C2133: 'buffer': unknown size > {code} > Thus, we need to use malloc to fix this. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org