[ https://issues.apache.org/jira/browse/HDFS-16671?focusedWorklogId=793434&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793434 ]
ASF GitHub Bot logged work on HDFS-16671: ----------------------------------------- Author: ASF GitHub Bot Created on: 20/Jul/22 21:11 Start Date: 20/Jul/22 21:11 Worklog Time Spent: 10m Work Description: goiri commented on code in PR #4597: URL: https://github.com/apache/hadoop/pull/4597#discussion_r926056965 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/StaticRouterRpcFairnessPolicyController.java: ########## @@ -109,16 +109,15 @@ public void init(Configuration conf) } private static void logAssignment(String nsId, int count) { - LOG.info("Assigned {} handlers to nsId {} ", - count, nsId); + LOG.info("Assigned {} handlers to nsId {} ", count, nsId); } - private void validateHandlersCount(Configuration conf, int handlerCount, - Set<String> allConfiguredNS) { + private void validateHandlersCount(Configuration conf, + int handlerCount, Set<String> allConfiguredNS) { int totalDedicatedHandlers = 0; for (String nsId : allConfiguredNS) { int dedicatedHandlers = - conf.getInt(DFS_ROUTER_FAIR_HANDLER_COUNT_KEY_PREFIX + nsId, 0); + conf.getInt(DFS_ROUTER_FAIR_HANDLER_COUNT_KEY_PREFIX + nsId, 0); Review Comment: Make it one line as we are touching this. ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/AbstractRouterRpcFairnessPolicyController.java: ########## @@ -42,15 +45,22 @@ /** Hash table to hold semaphore for each configured name service. */ private Map<String, Semaphore> permits; + private long acquireTimeout = DFS_ROUTER_FAIRNESS_ACQUIRE_TIMEOUT_DEFAULT; + public void init(Configuration conf) { this.permits = new HashMap<>(); + long timeout = conf.getLong(DFS_ROUTER_FAIRNESS_ACQUIRE_TIMEOUT_KEY, Review Comment: What's the unit? We should do getTimeDuration() Issue Time Tracking ------------------- Worklog Id: (was: 793434) Time Spent: 40m (was: 0.5h) > RBF: RouterRpcFairnessPolicyController supports configurable permit acquire > timeout > ----------------------------------------------------------------------------------- > > Key: HDFS-16671 > URL: https://issues.apache.org/jira/browse/HDFS-16671 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: ZanderXu > Assignee: ZanderXu > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > RouterRpcFairnessPolicyController supports configurable permit acquire > timeout. Hardcode 1s is very long, and it has causes an incident in our prod > environment when one nameserivce is busy. > And the optimal timeout maybe should be less than p50(avgTime). > And all handlers in RBF is waiting to acquire the permit of the busy ns. > {code:java} > "IPC Server handler 12 on default port 8888" #2370 daemon prio=5 os_prio=0 > tid=? nid=? waiting on condition [?] > java.lang.Thread.State: TIMED_WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <?> (a > java.util.concurrent.Semaphore$NonfairSync) > at > java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1037) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328) > at java.util.concurrent.Semaphore.tryAcquire(Semaphore.java:409) > at > org.apache.hadoop.hdfs.server.federation.fairness.AbstractRouterRpcFairnessPolicyController.acquirePermit(AbstractRouterRpcFairnessPolicyController.java:56) > at > org.apache.hadoop.hdfs.server.federation.fairness.DynamicRouterRpcFairnessPolicyController.acquirePermit(DynamicRouterRpcFairnessPolicyController.java:123) > at > org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.acquirePermit(RouterRpcClient.java:1500) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org