[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=795938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795938
]
ASF GitHub Bot logged work on HDFS-16658:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jul/22 05:35
Start Date: 28/Jul/22 05:35
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#issuecomment-1197684967
> The log size is controllable because `logEveryBlock` will control it. And
although it's a block-level log, it only printed the log when the replica of
the block is changed.
>
> Maybe we should think about its use. This log is very helpful for us to
locate some abnormal case about replica of block, such as complete failure,
missing block, etc...
Thanks for your explanation, I understand your changes.
Issue Time Tracking
-------------------
Worklog Id: (was: 795938)
Time Spent: 1h 10m (was: 1h)
> BlockManager should output some logs when logEveryBlock is true.
> ----------------------------------------------------------------
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
> final Block reportedBlock,
> DatanodeStorageInfo storageInfo,
> DatanodeDescriptor delNodeHint,
> boolean logEveryBlock)
> throws IOException {
> ....
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
