[
https://issues.apache.org/jira/browse/HDFS-16733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JiangHua Zhu updated HDFS-16733:
--------------------------------
Description:
When constructing an INodeFile or INodeDirectory, it is usually necessary to
give a name. For getLocalNameBytes, there are not many restrictions, such as
null can be set. But an exception is thrown:
{code:java}
INodeDirectory root = new INodeDirectory(HdfsConstants.GRANDFATHER_INODE_ID,
null, perm, 0L);
{code}
Some exceptions:
{code:java}
java.lang.NullPointerException
at org.apache.hadoop.hdfs.server.namenode.INode.isRoot(INode.java:78)
{code}
Although these situations rarely occur in production environments, we should
refine the implementation of isRoot() to avoid this exception. This can enhance
system robustness.
was:
When constructing an INodeFile or INodeDirectory, it is usually necessary to
give a name. For getLocalNameBytes, there are not many restrictions, such as
null can be set. But an exception is thrown:
{code:java}
INodeDirectory root = new INodeDirectory(HdfsConstants.GRANDFATHER_INODE_ID,
null, perm, 0L);
{code}
Some exceptions:
{code:java}
java.lang.NullPointerException
at org.apache.hadoop.hdfs.server.namenode.INode.isRoot(INode.java:78)
at
org.apache.hadoop.hdfs.server.namenode.TestINodeFile.testIsRoot(TestINodeFile.java:1274)
{code}
Although these situations rarely occur in production environments, we should
refine the implementation of isRoot() to avoid this exception. This can enhance
system robustness.
> Improve INode#isRoot()
> ----------------------
>
> Key: HDFS-16733
> URL: https://issues.apache.org/jira/browse/HDFS-16733
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.3.0
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Major
> Labels: pull-request-available
>
> When constructing an INodeFile or INodeDirectory, it is usually necessary to
> give a name. For getLocalNameBytes, there are not many restrictions, such as
> null can be set. But an exception is thrown:
> {code:java}
> INodeDirectory root = new INodeDirectory(HdfsConstants.GRANDFATHER_INODE_ID,
> null, perm, 0L);
> {code}
> Some exceptions:
> {code:java}
> java.lang.NullPointerException
> at org.apache.hadoop.hdfs.server.namenode.INode.isRoot(INode.java:78)
> {code}
> Although these situations rarely occur in production environments, we should
> refine the implementation of isRoot() to avoid this exception. This can
> enhance system robustness.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
