[
https://issues.apache.org/jira/browse/HDFS-16750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599188#comment-17599188
]
ASF GitHub Bot commented on HDFS-16750:
---------------------------------------
ZanderXu commented on PR #4821:
URL: https://github.com/apache/hadoop/pull/4821#issuecomment-1234911327
@goiri Sir, can help me to merger this pr into trunk?
> NameNode should use NameNode.getRemoteUser() to log audit event to avoid
> possible NPE
> --------------------------------------------------------------------------------------
>
> Key: HDFS-16750
> URL: https://issues.apache.org/jira/browse/HDFS-16750
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> NameNode should use NameNode.getRemoteUser() to log audit event to avoid
> possible NPE.
> The relate code is:
> {code:java}
> private void logAuditEvent(boolean succeeded, String cmd, String src,
> String dst, FileStatus stat) throws IOException {
> if (isAuditEnabled() && isExternalInvocation()) {
> logAuditEvent(succeeded, Server.getRemoteUser(), Server.getRemoteIp(),
> cmd, src, dst, stat);
> }
> }
> // the ugi may be null.
> private void logAuditEvent(boolean succeeded,
> UserGroupInformation ugi, InetAddress addr, String cmd, String src,
> String dst, FileStatus status) {
> final String ugiStr = ugi.toString();
> ...
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
