[jira] [Commented] (HDFS-16772) refreshHostsReader should use the new configuration

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/HDFS-16772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605090#comment-17605090
 ] 

ASF GitHub Bot commented on HDFS-16772:
---------------------------------------

ZanderXu opened a new pull request, #4890:
URL: https://github.com/apache/hadoop/pull/4890

   ### Description of PR
   `refreshHostsReader` should use the latest configuration and the related 
code as bellow:
   
   ```
   /** Reread include/exclude files. */
   private void refreshHostsReader(Configuration conf) throws IOException {
     if (conf == null) {
       conf = new HdfsConfiguration();
       // BUG here
       this.hostConfigManager.setConf(conf);
     }
     this.hostConfigManager.refresh();
   } 
   ```
   




> refreshHostsReader should use the new configuration
> ---------------------------------------------------
>
>                 Key: HDFS-16772
>                 URL: https://issues.apache.org/jira/browse/HDFS-16772
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: ZanderXu
>            Assignee: ZanderXu
>            Priority: Major
>
> `refreshHostsReader` should use the latest configuration.
> And the current code as bellow:
> {code:java}
> /** Reread include/exclude files. */
> private void refreshHostsReader(Configuration conf) throws IOException {
>   if (conf == null) {
>     conf = new HdfsConfiguration();
>     // BUG here
>     this.hostConfigManager.setConf(conf);
>   }
>   this.hostConfigManager.refresh();
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org