[ https://issues.apache.org/jira/browse/HDFS-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606810#comment-17606810 ]
ASF GitHub Bot commented on HDFS-16774: --------------------------------------- ZanderXu commented on code in PR #4903: URL: https://github.com/apache/hadoop/pull/4903#discussion_r974787840 ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetAsyncDiskService.java: ########## @@ -359,6 +371,89 @@ public void run() { IOUtils.cleanupWithLogger(null, this.volumeRef); } } + + private boolean removeReplicaFromMem() { + try (AutoCloseableLock lock = fsdatasetImpl.acquireDatasetLockManager().writeLock( + DataNodeLockManager.LockLevel.BLOCK_POOl, block.getBlockPoolId())) { + final ReplicaInfo info = fsdatasetImpl.volumeMap + .get(block.getBlockPoolId(), block.getLocalBlock()); + if (info == null) { + ReplicaInfo infoByBlockId = + fsdatasetImpl.volumeMap.get(block.getBlockPoolId(), + block.getLocalBlock().getBlockId()); + if (infoByBlockId == null) { + // It is okay if the block is not found > Improve async delete replica on datanode > ---------------------------------------- > > Key: HDFS-16774 > URL: https://issues.apache.org/jira/browse/HDFS-16774 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haiyang Hu > Assignee: Haiyang Hu > Priority: Major > Labels: pull-request-available > > In our online cluster, a large number of ReplicaNotFoundExceptions occur when > client reads the data. > After tracing the root cause, it is caused by the asynchronous deletion of > the replica operation has many stacked pending deletion caused > ReplicationNotFoundException. > Current the asynchronous delete of the replica operation process is as > follows: > 1.remove the replica from the ReplicaMap > 2.delete the replica file on the disk [blocked in threadpool] > 3.notifying namenode through IBR [blocked in threadpool] > In order to avoid similar problems as much as possible, consider optimizing > the execution flow: > The deleting replica from ReplicaMap, deleting replica from disk and > notifying namenode through IBR are processed in the same asynchronous thread. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org