[ https://issues.apache.org/jira/browse/HDFS-16804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617830#comment-17617830 ]
ASF GitHub Bot commented on HDFS-16804: --------------------------------------- hadoop-yetus commented on PR #5033: URL: https://github.com/apache/hadoop/pull/5033#issuecomment-1279199164 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 47s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 40m 2s | | trunk passed | | +1 :green_heart: | compile | 1m 33s | | trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | compile | 1m 30s | | trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | checkstyle | 1m 17s | | trunk passed | | +1 :green_heart: | mvnsite | 1m 43s | | trunk passed | | +1 :green_heart: | javadoc | 1m 22s | | trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javadoc | 1m 39s | | trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 3m 56s | | trunk passed | | +1 :green_heart: | shadedclient | 24m 53s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 18s | | the patch passed | | +1 :green_heart: | compile | 1m 23s | | the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javac | 1m 23s | | the patch passed | | +1 :green_heart: | compile | 1m 20s | | the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | javac | 1m 20s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 1m 1s | | the patch passed | | +1 :green_heart: | mvnsite | 1m 24s | | the patch passed | | +1 :green_heart: | javadoc | 0m 56s | | the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javadoc | 1m 24s | | the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 3m 32s | | the patch passed | | +1 :green_heart: | shadedclient | 23m 42s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 243m 56s | | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 7s | | The patch does not generate ASF License warnings. | | | | 357m 12s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5033/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/5033 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | Linux 98f882766699 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / db5e38ee013eba40619ae2fa512a692519dc0828 | | Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5033/1/testReport/ | | Max. process+thread count | 3030 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5033/1/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > AddVolume contains a race condition with shutdown block pool > ------------------------------------------------------------ > > Key: HDFS-16804 > URL: https://issues.apache.org/jira/browse/HDFS-16804 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: ZanderXu > Assignee: ZanderXu > Priority: Major > Labels: pull-request-available > > Add Volume contains a race condition with shutdown block pool, causing the > ReplicaMap still contains some blocks belong to the removed block pool. > And the new volume still contains one unused BlockPoolSlice belongs to the > removed block pool, caused some problems, such as: incorrect dfsUsed, > incorrect numBlocks of the volume. > Let's review the logic of addVolume and shutdownBlockPool respectively. > > AddVolume Logic: > * Step1: Get all namespaceInfo from blockPoolManager > * Step2: Create one temporary FsVolumeImpl object > * Step3: Create some blockPoolSlice according to the namespaceInfo and add > them to the temporary FsVolumeImpl object > * Step4: Scan all blocks of the namespaceInfo from the volume and store them > by one temporary ReplicaMap > * Step5: Active the temporary FsVolumeImpl which created before (with > FsDatasetImpl synchronized lock) > ** Step5.1: Merge all blocks of the temporary ReplicaMap to the global > ReplicaMap > ** Step5.2: Add the FsVolumeImpl to the volumes > ShutdownBlockPool Logic:(with blockPool write lock) > * Step1: Cleanup the blockPool from the global ReplicaMap > * Step2: Shutdown the block pool from all the volumes > ** Step2.1: do some clean operations for the block pool, such as > saveReplica, saveDfsUsed, etc > ** Step2.2: remove the blockPool from bpSlices > The race condition can be reproduced by the following steps: > * AddVolume Step1: Get all namespaceInfo from blockPoolManager > * ShutdownBlockPool Step1: Cleanup the blockPool from the global ReplicaMap > * ShutdownBlockPool Step2: Shutdown the block pool from all the volumes > * AddVolume Step 2~5 > And result: > * The global replicaMap contains some blocks belong to the removed blockPool > * The bpSlices of the FsVolumeImpl contains one blockPoolSlice belong to the > removed blockPool > Expected result: > * The global replicaMap shouldn't contain any blocks belong to the removed > blockPool > * The bpSlices of any FsVolumeImpl shouldn't contain any blockPoolSlice > belong to the removed blockPool -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org