[ https://issues.apache.org/jira/browse/HDFS-16816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623323#comment-17623323 ]
ASF GitHub Bot commented on HDFS-16816: --------------------------------------- mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1003606901 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ########## @@ -144,6 +144,40 @@ private boolean addMountTable(final MountTable entry) throws IOException { return addResponse.getStatus(); } + @Test + public void testMoveToTrashAutoCreateUserHome() throws IOException, URISyntaxException, InterruptedException { Review Comment: CAn you create a negative test case: where the user directory already exists we don't create it. > RBF: auto-create user home dir for trash paths by router > -------------------------------------------------------- > > Key: HDFS-16816 > URL: https://issues.apache.org/jira/browse/HDFS-16816 > Project: Hadoop HDFS > Issue Type: Improvement > Components: rbf > Reporter: Xing Lin > Priority: Minor > Labels: pull-request-available > > In RBF, trash files are moved to trash root under user's home dir at the > corresponding namespace/namenode where the files reside. This was added in > HDFS-16024. When the user home dir is not created before-hand at a namenode, > we run into permission denied exceptions when trying to create the parent dir > for the trash file before moving the file into it. We propose to enhance > Router, to auto-create a user home's dir at the namenode for trash paths, > using router's identity (which is assumed to be a super-user). -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org