[ https://issues.apache.org/jira/browse/HDFS-16740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623367#comment-17623367 ]
ASF GitHub Bot commented on HDFS-16740: --------------------------------------- snmvaughan commented on code in PR #4835: URL: https://github.com/apache/hadoop/pull/4835#discussion_r1003680369 ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniJournalCluster.java: ########## @@ -64,7 +65,17 @@ public static class Builder { public Builder(Configuration conf) { this.conf = conf; } - + + public Builder(Configuration conf, TemporaryFolder baseDir) { Review Comment: I can remove the JUnit dependency, but I was thinking it would be useful to differentiate between those instances that had been updated to use the TemporaryFolder handling. > Mini cluster test flakiness > --------------------------- > > Key: HDFS-16740 > URL: https://issues.apache.org/jira/browse/HDFS-16740 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs, test > Affects Versions: 3.4.0, 3.3.5 > Reporter: Steve Vaughan > Assignee: Steve Vaughan > Priority: Major > Labels: pull-request-available > > Mini clusters used during HDFS unit tests are reporting test failures that do > not appear to be directly related to submitted changes. The failures are the > result of either interactions between tests run in parallel, or tests which > share common disk space for tests. In all cases, the tests can be run > individually serially without any errors. Addressing this issue will > simplify future submissions by eliminating the confusion introduced by these > unrelated test failures. > We can apply lessons recently from TestRollingUpgrade, which was recently > patched to unblock a recent submission. The fixes involved changing the HDFS > configuration to use temporary disk space for each individual tests, and > using try-with-resources to ensure that clusters were shutdown cleanly. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org