[ https://issues.apache.org/jira/browse/HDFS-16817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623550#comment-17623550 ]
ASF GitHub Bot commented on HDFS-16817: --------------------------------------- haiyang1987 commented on PR #5072: URL: https://github.com/apache/hadoop/pull/5072#issuecomment-1289946349 Hi @ferhui @ZanderXu @Hexiaoqiao Can you help to review this simple modification? > Remove useless DataNode lock related configuration > -------------------------------------------------- > > Key: HDFS-16817 > URL: https://issues.apache.org/jira/browse/HDFS-16817 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haiyang Hu > Assignee: Haiyang Hu > Priority: Major > Labels: pull-request-available > > When look at the code related to DataNode lock, it is found that the relevant > configuration are invalid and maybe can be removed > {code:java} > public static final String DFS_DATANODE_LOCK_READ_WRITE_ENABLED_KEY = > "dfs.datanode.lock.read.write.enabled"; > public static final Boolean DFS_DATANODE_LOCK_READ_WRITE_ENABLED_DEFAULT = > true; > public static final String DFS_DATANODE_LOCK_REPORTING_THRESHOLD_MS_KEY = > "dfs.datanode.lock-reporting-threshold-ms"; > public static final long > DFS_DATANODE_LOCK_REPORTING_THRESHOLD_MS_DEFAULT = 300L; > <property> > <name> dfs.datanode.lock.read.write.enabled </name> > <value> true </value> > <description> If this is true, the FsDataset lock will be a read write lock. > If > it is false, all locks will be a write lock. > Enabling this should give better datanode throughput, as many read only > functions can run concurrently under the read lock, when they would > previously have required the exclusive write lock. As the feature is > experimental, this switch can be used to disable the shared read lock, and > cause all lock acquisitions to use the exclusive write lock. > </description> > </property> > <property> > <name> dfs.datanode.lock-reporting-threshold-ms </name> > <value> 300 </value> > <description> When thread waits to obtain a lock, or a thread holds a lock for > more than the threshold, a log message will be written. Note that > dfs.lock.suppress.warning.interval ensures a single log message is > emitted per interval for waiting threads and a single message for holding > threads to avoid excessive logging. > </description> > </property> > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org