[
https://issues.apache.org/jira/browse/HDFS-16826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630347#comment-17630347
]
ASF GitHub Bot commented on HDFS-16826:
---------------------------------------
ZanderXu commented on PR #5086:
URL: https://github.com/apache/hadoop/pull/5086#issuecomment-1307028961
> > @simbadzina @omalley Sir, can help me review this PR when you are
available?
>
> Sure. I'll take a look.
@simbadzina @goiri @omalley Ping, can help me review this bug when you are
available? Thanks so much.
> [RBF SBN] ConnectionManager should advance the client stateId for every
> request
> -------------------------------------------------------------------------------
>
> Key: HDFS-16826
> URL: https://issues.apache.org/jira/browse/HDFS-16826
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> ConnectionManager should advance the client stateId for every request
> whatever pool is null or not.
>
> Bug Code as bellow:
> {code:java}
> // Create the pool if not created before
> if (pool == null) {
> writeLock.lock();
> try {
> pool = this.pools.get(connectionId);
> if (pool == null) {
> pool = new ConnectionPool(
> this.conf, nnAddress, ugi, this.minSize, this.maxSize,
> this.minActiveRatio, protocol,
> new PoolAlignmentContext(this.routerStateIdContext, nsId));
> this.pools.put(connectionId, pool);
> this.connectionPoolToNamespaceMap.put(connectionId, nsId);
> }
> // BUG Here
> long clientStateId =
> RouterStateIdContext.getClientStateIdFromCurrentCall(nsId);
> pool.getPoolAlignmentContext().advanceClientStateId(clientStateId);
> } finally {
> writeLock.unlock();
> }
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
