[
https://issues.apache.org/jira/browse/HDFS-16845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636813#comment-17636813
]
ASF GitHub Bot commented on HDFS-16845:
---------------------------------------
mkuchenbecker commented on code in PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#discussion_r1028371062
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestObserverWithRouter.java:
##########
@@ -122,7 +123,9 @@ public void startUpCluster(int numberOfObserver,
Configuration confOverrides) th
cluster.waitActiveNamespaces();
routerContext = cluster.getRandomRouter();
- fileSystem = routerContext.getFileSystemWithObserverReadsEnabled();
+ Configuration confToEnableObserverRead = new Configuration();
+
confToEnableObserverRead.setBoolean(HdfsClientConfigKeys.DFS_RBF_OBSERVER_READ_ENABLE,
true);
+ fileSystem = routerContext.getFileSystem(confToEnableObserverRead);
Review Comment:
We are losing coverage on `getFileSystemWithObserverReadsEnabled` with this
change; we should likely be testing both as they are both valid use-cases
whether you want to msync or not.
> Add configuration flag to enable observer reads on routers without using
> ObserverReadProxyProvider
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-16845
> URL: https://issues.apache.org/jira/browse/HDFS-16845
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Critical
> Labels: pull-request-available
>
> In order for clients to have routers forward their reads to observers, the
> clients must use a proxy with an alignment context. This is currently
> achieved by using the ObserverReadProxyProvider.
> Using ObserverReadProxyProvider allows backward compatible for client
> configurations.
> However, the ObserverReadProxyProvider forces an msync on initialization
> which is not required with routers.
> Performing msync calls is more expensive with routers because the router fans
> out the cal to all namespaces, so we'd like to avoid this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
