[ https://issues.apache.org/jira/browse/HDFS-16837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638419#comment-17638419 ]
ASF GitHub Bot commented on HDFS-16837: --------------------------------------- goiri commented on code in PR #5123: URL: https://github.com/apache/hadoop/pull/5123#discussion_r1031848388 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/proto/FederationProtocol.proto: ########## @@ -311,17 +311,4 @@ message GetDisabledNameservicesRequestProto { message GetDisabledNameservicesResponseProto { repeated string nameServiceIds = 1; -} - -///////////////////////////////////////////////// -// Alignment state for namespaces. -///////////////////////////////////////////////// - -/** - * Clients should receive this message in RPC responses and forward it - * in RPC requests without interpreting it. It should be encoded - * as an obscure byte array when being sent to clients. - */ -message RouterFederatedStateProto { - map<string, int64> namespaceStateIds = 1; // Last seen state IDs for multiple namespaces. Review Comment: @ayushtkn do you think is fine moving this around? > [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max > state id for each namespace > -------------------------------------------------------------------------------------------------------- > > Key: HDFS-16837 > URL: https://issues.apache.org/jira/browse/HDFS-16837 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: ZanderXu > Assignee: ZanderXu > Priority: Major > Labels: pull-request-available > > ClientGSIContext should merge local and remote RouterFederatedState to get > the max state id for each namespace. > And the related code as bellows: > {code:java} > @Override > public synchronized void receiveResponseState(RpcResponseHeaderProto header) { > if (header.hasRouterFederatedState()) { > // BUG here > routerFederatedState = header.getRouterFederatedState(); > } else { > lastSeenStateId.accumulate(header.getStateId()); > } > } {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org