[
https://issues.apache.org/jira/browse/HDFS-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642783#comment-17642783
]
ASF GitHub Bot commented on HDFS-16859:
---------------------------------------
hfutatzhanghb commented on code in PR #5181:
URL: https://github.com/apache/hadoop/pull/5181#discussion_r1038724828
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/AbstractRouterRpcFairnessPolicyController.java:
##########
@@ -63,10 +63,14 @@ public void init(Configuration conf) {
@Override
public boolean acquirePermit(String nsId) {
try {
- LOG.debug("Taking lock for nameservice {}", nsId);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Taking lock for nameservice {}", nsId);
Review Comment:
i.m sorry, @goiri , here does not need if condition statement exactlly. i
will close this pr.
> acquirePermit : move LOG.debug into if condition
> ------------------------------------------------
>
> Key: HDFS-16859
> URL: https://issues.apache.org/jira/browse/HDFS-16859
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Affects Versions: 3.3.4
> Reporter: ZhangHB
> Priority: Major
> Labels: pull-request-available
>
> The invoke frequency of method
> AbstractRouterRpcFairnessPolicyController#acquirePermit is high. before
> getting the permit of a nameservice, there is always a LOG.debug statement.
> It is better to move the statement into if condition statement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
