[
https://issues.apache.org/jira/browse/HDFS-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195024#comment-13195024
]
Suresh Srinivas commented on HDFS-2843:
---------------------------------------
bq. Also, what about my other concern from earlier? I can probably be convinced
that a name change for StorageInfo is in order, but not StorageInfoProto in
isolation:
Sorry I did not address it. My plan was to do this change as well for
StorageInfo.
bq. I don't see how this fact makes it necessarily not storage. All those
things have "storage" directories as well.
May be we are thinking about the abstractions differently. To me in HDFS
cluster is made of nodes. Each node has the following information:
* ClusterID - for membership purposes
* namespaceID - to bind namenodes, secondary/backup, datanodes to be serving a
namespace
* layoutVersion - for compatibility checks and to ensure
upgrade/snapshot/rollback
* cTime - namespace related information to trigger upgrades
To me storage is more of what Datanode is exposing to the namenode. It has
storageID, storage utilization (available, free space etc.) This is exposed
only by datanode.
Currently what are the subclasses of StorageInfo:
CheckPointSignature, NamenodeRegistration, NamespaceInfo, Storage -> {
BlockPoolSliceStorage, DataStorage, NNStorage}
Out of this Storage is the one that has Storage directories, Version file etc
and not StorageInfo.
I think, you have probably misunderstood my proposal. I am not proposing making
changes in directory structure. Hence your upgrade questions on what happens
when partial upgrade happened, layoutVersion is different etc. is some thing
that already exists, which this patch does not touch. I am changing the
organization to (if you see the patch, it should be clear).
StorageInfo to NodeInfo, which captures all the information about a node
exchanged over protocol.
CheckPointSignature, NamenodeRegistration, NamespaceInfo, Storage use NodeInfo,
without the need for inheritance.
> Rename protobuf message StorageInfoProto to NodeInfoProto
> ---------------------------------------------------------
>
> Key: HDFS-2843
> URL: https://issues.apache.org/jira/browse/HDFS-2843
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-2843.patch
>
>
> StorageInfoProto has cTime, layoutVersion, namespaceID and clusterID. This is
> really information of a node that is part of the cluster, such as Namenode,
> Standby/Secondary/Backup/Checkpointer and datanodes. To reflect this, I want
> to rename it as NodeInfoProto from StorageInfoProto.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
