[ https://issues.apache.org/jira/browse/HDFS-16892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678064#comment-17678064 ]
ASF GitHub Bot commented on HDFS-16892: --------------------------------------- ayushtkn commented on code in PR #5301: URL: https://github.com/apache/hadoop/pull/5301#discussion_r1073077149 ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java: ########## @@ -901,7 +901,7 @@ public Builder setNumHandlers(int numHandlers) { * @return Default: -1. * @param numReaders input numReaders. */ - public Builder setnumReaders(int numReaders) { + public Builder setNumReaders(int numReaders) { Review Comment: Is this ok from compatibility point of view, it is a public method in a public class. if any downstream project is using it, they will get compilation failures? this method seems to be there since 2012, so pretty old as well... > Fix method name of RPC.Builder#setnumReaders > --------------------------------------------- > > Key: HDFS-16892 > URL: https://issues.apache.org/jira/browse/HDFS-16892 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haiyang Hu > Assignee: Haiyang Hu > Priority: Minor > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org