[ https://issues.apache.org/jira/browse/HDFS-16898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683979#comment-17683979 ]
ASF GitHub Bot commented on HDFS-16898: --------------------------------------- virajjasani commented on PR #5330: URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1416207201 In the meantime, I have two nits if you would like to consider: 1. For `processCommandFromActive` and `processCommandFromStandby`, it would be good to pass only `actor.getNNSocketAddress()` instead of `actor`, because it's the namenode address that is logged for `BlockRecoveryWorker` logs and others in standby. 2. Would be great to change log level to WARN for this: ``` if (processCommandsMs > dnConf.getProcessCommandsThresholdMs()) { LOG.info("Took {} ms to process {} commands from NN", processCommandsMs, cmds.length); } ``` With WARN level, it will likely come up front while debugging any slowness issues. > Make write lock fine-grain in processCommandFromActor method > ------------------------------------------------------------ > > Key: HDFS-16898 > URL: https://issues.apache.org/jira/browse/HDFS-16898 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 3.3.4 > Reporter: ZhangHB > Priority: Major > Labels: pull-request-available > > Now in method processCommandFromActor, we have code like below: > > {code:java} > writeLock(); > try { > if (actor == bpServiceToActive) { > return processCommandFromActive(cmd, actor); > } else { > return processCommandFromStandby(cmd, actor); > } > } finally { > writeUnlock(); > } {code} > if method processCommandFromActive costs much time, the write lock would not > release. > > It maybe block the updateActorStatesFromHeartbeat method in > offerService,furthermore, it can cause the lastcontact of datanode very high, > even dead when lastcontact beyond 600s. > {code:java} > bpos.updateActorStatesFromHeartbeat( > this, resp.getNameNodeHaState());{code} > here we can make write lock fine-grain in processCommandFromActor method to > address this problem > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org