[
https://issues.apache.org/jira/browse/HDFS-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196018#comment-13196018
]
Jitendra Nath Pandey commented on HDFS-2718:
--------------------------------------------
Is it ok to add lease in all cases of OP_ADD, what if a lease already exists?
It seems to me it should be fine as the existing lease will just be renewed,
please confirm.
{code}
diskspace = ((INodeFile)newNode).diskspaceConsumed(blocks);
{code}
If blocks are null diskspace will be zero. In the existing code it is -1
(UNKNOWN_DISK_SPACE).
{code}
if(getBlockUCState() != BlockUCState.COMMITTED)
throw new IOException(
"Cannot complete block: block has not been COMMITTED by the client");
{code}
Please clarify why this code was removed from convertToCompleteBlock and moved
to the caller.
> Optimize OP_ADD in edits loading
> --------------------------------
>
> Key: HDFS-2718
> URL: https://issues.apache.org/jira/browse/HDFS-2718
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.22.0, 0.24.0, 1.0.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Attachments: editsLoader-0.22.patch, editsLoader-trunk.patch,
> editsLoader-trunk.patch
>
>
> During loading the edits journal FSEditLog.loadEditRecords() processes OP_ADD
> inefficiently. It first removes the existing INodeFile from the directory
> tree, then adds it back as a regular INodeFile, and then replaces it with
> INodeFileUnderConstruction if files is not closed. This slows down edits
> loading. OP_ADD should be done in one shot and retain previously existing
> data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
