[ https://issues.apache.org/jira/browse/HDFS-16935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694594#comment-17694594 ]
ASF GitHub Bot commented on HDFS-16935: --------------------------------------- steveloughran commented on code in PR #5432: URL: https://github.com/apache/hadoop/pull/5432#discussion_r1120168448 ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java: ########## @@ -1101,15 +1099,11 @@ public void testReportBadBlocks() throws Exception { block = DFSTestUtil.getFirstBlock(fs, filePath); // Test for the overloaded method reportBadBlocks - dataNode.reportBadBlocks(block, dataNode.getFSDataset() - .getFsVolumeReferences().get(0)); - Thread.sleep(3000); - BlockManagerTestUtil.updateState(cluster.getNamesystem() - .getBlockManager()); - // Verify the bad block has been reported to namenode - Assert.assertEquals(1, cluster.getNamesystem().getCorruptReplicaBlocks()); - } finally { - cluster.shutdown(); + dataNode.reportBadBlocks(block, dataNode.getFSDataset().getFsVolumeReferences().get(0)); + DataNodeTestUtils.triggerHeartbeat(dataNode); Review Comment: this is why we don't need a sleep() any more, right? if so, yes, it fixes the problem deterministically > TestFsDatasetImpl.testReportBadBlocks brittle > --------------------------------------------- > > Key: HDFS-16935 > URL: https://issues.apache.org/jira/browse/HDFS-16935 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Affects Versions: 3.4.0, 3.3.5, 3.3.9 > Reporter: Steve Loughran > Assignee: Viraj Jasani > Priority: Minor > Labels: pull-request-available > > jenkins failure as sleep() time not long enough > {code} > Failing for the past 1 build (Since #4 ) > Took 7.4 sec. > Error Message > expected:<1> but was:<0> > Stacktrace > java.lang.AssertionError: expected:<1> but was:<0> > at org.junit.Assert.fail(Assert.java:89) > at org.junit.Assert.failNotEquals(Assert.java:835) > at org.junit.Assert.assertEquals(Assert.java:647) > at org.junit.Assert.assertEquals(Assert.java:633) > {code} > assert is after a 3s sleep waiting for reports coming in. > {code} > dataNode.reportBadBlocks(block, dataNode.getFSDataset() > .getFsVolumeReferences().get(0)); > Thread.sleep(3000); // 3s > sleep > BlockManagerTestUtil.updateState(cluster.getNamesystem() > .getBlockManager()); > // Verify the bad block has been reported to namenode > Assert.assertEquals(1, > cluster.getNamesystem().getCorruptReplicaBlocks()); // here > {code} > LambdaTestUtils.eventually() should be used around this assert, maybe with an > even shorter initial delay so on faster systems, test is faster. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org