[
https://issues.apache.org/jira/browse/HDFS-16957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701515#comment-17701515
]
ASF GitHub Bot commented on HDFS-16957:
---------------------------------------
ayushtkn commented on PR #5487:
URL: https://github.com/apache/hadoop/pull/5487#issuecomment-1473155719
yep, that is something known to me, it is there with almost all commands,
and we had a discussion around it long back and it was kind of: 'Changing exit
code is incompatible', remember discussing internally long back as well and the
conclusion was people who have internal test scripts and code they heavily rely
on these exit code(we were one of those then), so, it got dropped.
> Would you recommend fixing them all once and for all on trunk (3.4.0)
I won't say yes, have always been part of the gang or say I come from that
era which was strong believer and follower of compat guidelines. Not sure how
people are dealing nowadays though :(
see this ex., just a minor CLI change which in all ways is good very useful
got reverted just because of compat from all branches. that is some fun to
follow
https://issues.apache.org/jira/browse/HDFS-13732
> RBF: Exit status of dfsrouteradmin -rm should be non-zero for unsuccessful
> attempt
> ----------------------------------------------------------------------------------
>
> Key: HDFS-16957
> URL: https://issues.apache.org/jira/browse/HDFS-16957
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> DFS router admin returns non-zero status code for unsuccessful attempt to add
> or update mount point. However, same is not the case with removal of mount
> point.
> For instance,
> {code:java}
> bin/hdfs dfsrouteradmin -add /data4 ns1 /data4
> ..
> ..
> Cannot add destination at ns1 /data4
> echo $?
> 255 {code}
> {code:java}
> /hadoop/bin/hdfs dfsrouteradmin -rm /data4
> ..
> ..
> Cannot remove mount point /data4
> echo $?
> 0{code}
> Removal of mount point should stay consistent with other options and return
> non-zero (unsuccessful) status code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
