[
https://issues.apache.org/jira/browse/HDFS-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707483#comment-17707483
]
ASF GitHub Bot commented on HDFS-16943:
---------------------------------------
simbadzina commented on code in PR #5469:
URL: https://github.com/apache/hadoop/pull/5469#discussion_r1155038678
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/StateStoreDriver.java:
##########
@@ -35,6 +36,7 @@
* provider. Driver implementations will extend this class and implement some
of
* the default methods.
*/
+@InterfaceAudience.Public
Review Comment:
It is possible to statically import Public, but I think it makes the code
less readable having just `@Public` vs `@InterfaceAudience.Public`.
The oracle documentation also only recommends static imports when there is
frequent access to the value.
https://docs.oracle.com/javase/7/docs/technotes/guides/language/static-import.html#:~:text=So%20when%20should%20you%20use,from%20one%20or%20two%20classes.
> RBF: Implement MySQL based StateStoreDriver
> -------------------------------------------
>
> Key: HDFS-16943
> URL: https://issues.apache.org/jira/browse/HDFS-16943
> Project: Hadoop HDFS
> Issue Type: Task
> Components: hdfs, rbf
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Major
> Labels: pull-request-available
>
> RBF supports two types of StateStoreDrivers
> # StateStoreFileImpl
> # StateStoreZooKeeperImpl
> I propose implementing a third driver that is backed by MySQL.
> * StateStoreZooKeeperImpl requires an additional Zookeeper cluster.
> * StateStoreFileImpl can use one of the namenodes in the HDFS cluster, but
> that namenode becomes a single point of failure, introducing coupling between
> the federated clusters.
> HADOOP-18535 implemented a MySQL token store. When tokens are stored in
> MySQL, using MySQL for the StateStore as well reduces the number of external
> dependencies for routers.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
