[
https://issues.apache.org/jira/browse/HDFS-16973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709028#comment-17709028
]
ASF GitHub Bot commented on HDFS-16973:
---------------------------------------
goiri commented on code in PR #5533:
URL: https://github.com/apache/hadoop/pull/5533#discussion_r1158812807
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/resolver/TestMountTableResolver.java:
##########
@@ -552,6 +552,10 @@ public void testMountTableScalability() throws IOException
{
assertEquals(100000, mountTable.getMountPoints("/").size());
assertEquals(100000, mountTable.getMounts("/").size());
+ for (int i = 0; i < 20; i++) {
Review Comment:
Add a comment saying this is for testing concurrency.
> RBF: MountTableResolver cache size lookup should take read lock
> ---------------------------------------------------------------
>
> Key: HDFS-16973
> URL: https://issues.apache.org/jira/browse/HDFS-16973
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> Mount table resolver location cache gets invalidated by taking write lock as
> part of addEntry/removeEntry/refreshEntries calls. Since the write lock
> exclusively updates the cache, getDestinationForPath already takes read lock
> before accessing the cache. Similarly, retrieval of the cache size should
> also take the read lock.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
