[ https://issues.apache.org/jira/browse/HDFS-16979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712180#comment-17712180 ]
ASF GitHub Bot commented on HDFS-16979: --------------------------------------- virajjasani commented on code in PR #5552: URL: https://github.com/apache/hadoop/pull/5552#discussion_r1166242347 ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ########## @@ -461,6 +462,14 @@ private void appendClientPortToCallerContextIfAbsent() { .append(CallerContext.CLIENT_PORT_STR, String.valueOf(Server.getRemotePort())) .setSignature(origSignature) .build()); + } else { + String origContext = ctx == null ? null : ctx.getContext(); + byte[] origSignature = ctx == null ? null : ctx.getSignature(); Review Comment: Since it is redundant check, we can remove `ctx == null ? null : ` from both L466-L467 correct? > RBF: Add dfsrouter port in hdfsauditlog > --------------------------------------- > > Key: HDFS-16979 > URL: https://issues.apache.org/jira/browse/HDFS-16979 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: liuguanghua > Priority: Major > Labels: pull-request-available > > When remote client request through dfsrouter to namenode, the hdfsauditlog > record the remote client ip and port ,dfsrouter IP,but lack of dfsrouter port. > This patch is done for this scene. > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org