[ https://issues.apache.org/jira/browse/HDFS-16979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719315#comment-17719315 ]
ASF GitHub Bot commented on HDFS-16979: --------------------------------------- ayushtkn commented on code in PR #5552: URL: https://github.com/apache/hadoop/pull/5552#discussion_r1184989929 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestNamenodeAuditlogWithDFSRouterPort.java: ########## @@ -0,0 +1,91 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdfs.server.federation.router; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hdfs.server.federation.MiniRouterDFSCluster; +import org.apache.hadoop.hdfs.server.federation.RouterConfigBuilder; +import org.apache.hadoop.hdfs.server.namenode.FSNamesystem; +import org.apache.hadoop.test.GenericTestUtils; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.regex.Pattern; + +import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.HADOOP_CALLER_CONTEXT_ENABLED_KEY; +import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_NAMENODE_AUDIT_LOG_WITH_REMOTE_PORT_KEY; +import static org.junit.Assert.assertTrue; + +/** + * Test namenode auditlog log the dfsrouterPort info when the request is form dfsrouter. + */ +public class TestNamenodeAuditlogWithDFSRouterPort { + private static final Logger LOG = LoggerFactory.getLogger( + TestNamenodeAuditlogWithDFSRouterPort.class); + private static final Pattern AUDIT_WITH_PORT_PATTERN = Pattern.compile( Review Comment: TestRouterRpc is in hadoop-rbf only, why you need to add hdfs-rbf jar hadoop-hdfs? > RBF: Add dfsrouter port in hdfsauditlog > --------------------------------------- > > Key: HDFS-16979 > URL: https://issues.apache.org/jira/browse/HDFS-16979 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: liuguanghua > Priority: Major > Labels: pull-request-available > > When remote client request through dfsrouter to namenode, the hdfsauditlog > record the remote client ip and port ,dfsrouter IP,but lack of dfsrouter port. > This patch is done for this scene. > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org