[ https://issues.apache.org/jira/browse/HDFS-16965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721581#comment-17721581 ]
ASF GitHub Bot commented on HDFS-16965: --------------------------------------- tomscut commented on code in PR #5520: URL: https://github.com/apache/hadoop/pull/5520#discussion_r1190559444 ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/CodecUtil.java: ########## @@ -78,6 +78,10 @@ public final class CodecUtil { public static final String IO_ERASURECODE_CODEC_XOR_RAWCODERS_KEY = IO_ERASURECODE_CODEC + "xor.rawcoders"; + public static final String IO_ERASURECODE_CODEC_NATIVE_ENABLED_KEY = "io.erasurecode.codec.native.enabled"; Review Comment: > @tomscut Thank you for your suggestion. I'v updated the code and could you review again please? Thanks. Now, it looks good to me. > Add switch to decide whether to enable native codec. > ---------------------------------------------------- > > Key: HDFS-16965 > URL: https://issues.apache.org/jira/browse/HDFS-16965 > Project: Hadoop HDFS > Issue Type: New Feature > Components: erasure-coding > Affects Versions: 3.3.4 > Reporter: WangYuanben > Priority: Minor > Labels: pull-request-available > > Sometimes we need to create codec without ISA-L, while priority is given to > native codec by default. So it is necessary to add switch to decide whether > to enable native codec. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org