[ 
https://issues.apache.org/jira/browse/HDFS-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726473#comment-17726473
 ] 

ASF GitHub Bot commented on HDFS-17026:
---------------------------------------

hchaverri opened a new pull request, #5691:
URL: https://github.com/apache/hadoop/pull/5691

   …er frequency
   
   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   Changes to the NamenodeHeartbeatService to update JMX reports on a 
configurable frequency or to disable JMX updates altogether, as opposed to 
updating it every time the service wakes up. This will help reduce the load on 
Namenodes in clusters with a high number of routers.
   With these changes, we expect the NamenodeStatusReport to contain slightly 
outdated Namenode information, which should not impact critical paths for 
routers.
   
   ### How was this patch tested?
   Added unit test on TestRouterNamenodeMonitoring#testJmxRequestFrequency that 
tests the following configurations:
   1. Default configuration which should update JMX every time the report is 
generated.
   2. Configuration with JMX updates disabled, which should never update JMX
   3. Configuration with a high JMX update interval, which should not update 
JMX every time the report is generated.
   
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [X] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [X] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> RBF: NamenodeHeartbeatService should update JMX report with configurable 
> frequency
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-17026
>                 URL: https://issues.apache.org/jira/browse/HDFS-17026
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>            Reporter: Hector Sandoval Chaverri
>            Priority: Major
>
> The NamenodeHeartbeatService currently calls each of the Namenode's JMX 
> endpoint every time it wakes up (default value is every 5 seconds).
> In a cluster with 40 routers, we have observed service degradation on some of 
> the  Namenodes, since the JMX request obtains Datanode status and blocks 
> other RPC requests. However, JMX report data doesn't seem to be used for 
> critical paths on the routers.
> We should configure the NamenodeHeartbeatService so it updates the JMX 
> reports on a slower frequency than the Namenode states or to disable the 
> reports completely.
> The class calls out the JMX request being optional even though there is no 
> implementation to turn it off:
> {noformat}
> // Read the stats from JMX (optional)
> updateJMXParameters(webAddress, report);{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to