[ https://issues.apache.org/jira/browse/HDFS-17028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728902#comment-17728902 ]
ASF GitHub Bot commented on HDFS-17028: --------------------------------------- ayushtkn commented on code in PR #5694: URL: https://github.com/apache/hadoop/pull/5694#discussion_r1215139609 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java: ########## @@ -482,7 +482,7 @@ public void run() { pool.getMaxSize(), pool); } } catch (IOException e) { - LOG.error("Cannot create a new connection", e); + LOG.error("Cannot create a new connection for {} {}", pool, e.toString()); Review Comment: Should have stayed ``` LOG.error("Cannot create a new connection for {} {}", pool, e); ``` > RBF: Optimize debug logs of class ConnectionPool and other related class. > ------------------------------------------------------------------------- > > Key: HDFS-17028 > URL: https://issues.apache.org/jira/browse/HDFS-17028 > Project: Hadoop HDFS > Issue Type: Improvement > Components: rbf > Affects Versions: 3.3.4 > Reporter: farmmamba > Priority: Minor > Labels: pull-request-available > > When we change the log level of RouterRpcClient from INFO to DEBUG to figure > out which connection an user is using. We found logs below: > > {code:java} > 2023-05-29 09:46:09,033 DEBUG > org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient: User someone > NN ANN:8020 is using connection > ClientNamenodeProtocolTranslatorPB@ANN/ANN_IP:8020x3 > 2023-05-29 09:46:09,037 DEBUG > org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient: User someone > NN ANN:8020 is using connection > ClientNamenodeProtocolTranslatorPB@ANN/ANN_IP:8020x1 > 2023-05-29 09:46:09,037 DEBUG > org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient: User someone > NN ANN:8020 is using connection > ClientNamenodeProtocolTranslatorPB@ANN/ANN_IP:8020x2 > 2023-05-29 09:46:09,037 DEBUG > org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient: User someone > NN ANN:8020 is using connection > ClientNamenodeProtocolTranslatorPB@ANN/ANN_IP:8020x3 > 2023-05-29 09:46:09,042 DEBUG > org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient: User someone > NN ANN:8020 is using connection > ClientNamenodeProtocolTranslatorPB@ANN/ANN_IP:8020x0 {code} > It seems not very clear for us to figure out which connection user is using. > Therefore, i think we should optimize the toString method of class > ConnectionContext. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org