[ https://issues.apache.org/jira/browse/HDFS-17037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729908#comment-17729908 ]
ASF GitHub Bot commented on HDFS-17037: --------------------------------------- Hexiaoqiao commented on code in PR #5715: URL: https://github.com/apache/hadoop/pull/5715#discussion_r1220778098 ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancingPolicy.java: ########## @@ -104,21 +104,21 @@ void accumulateSpaces(DatanodeStorageReport r) { for(StorageReport s : r.getStorageReports()) { Review Comment: It makes sense to me. > Consider nonDfsUsed when running balancer > ----------------------------------------- > > Key: HDFS-17037 > URL: https://issues.apache.org/jira/browse/HDFS-17037 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Shuyan Zhang > Assignee: Shuyan Zhang > Priority: Major > Labels: pull-request-available > > When we run balancer with `BalancingPolicy.Node` policy, our goal is to make > each datanode storage balanced. But in the current implementation, the > balancer doesn't account for storage used by non-dfs on the datanodes, which > can make the situation worse for datanodes that are already strained on > storage. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org