[ 
https://issues.apache.org/jira/browse/HDFS-17040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730028#comment-17730028
 ] 

ASF GitHub Bot commented on HDFS-17040:
---------------------------------------

szetszwo commented on code in PR #5721:
URL: https://github.com/apache/hadoop/pull/5721#discussion_r1221248416


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js:
##########
@@ -518,7 +518,8 @@
             url: url,
             data: file.file,
             processData: false,
-            crossDomain: true
+            crossDomain: true,
+            contentType: 'application/octet-stream'

Review Comment:
   The list is the default values.  It can be overridden by init parameter; see
   
https://github.com/apache/hadoop/blob/9de13f879af66a211b098166fd423b6900fc730d/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java#L176-L185





> WebHDFS UI should set content type to application/octet-stream when uploading 
> a file
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-17040
>                 URL: https://issues.apache.org/jira/browse/HDFS-17040
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: Attila Magyar
>            Priority: Major
>              Labels: pull-request-available
>
> When uploading a file WebHDFS will set the content type to 
> application/x-www-form-urlencoded, as this is the default used by jQuery
> https://github.com/apache/hadoop/blob/160b9fc3c9255024c00d487b7fcdf5ea59a42781/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js#L516
> This causes knox to urlencode the request body so that uploading a CVS file 
> 1,2,3 will result 1%2C2%2C3.
> Instead of application/x-www-form-urlencoded I think the encoding should be 
> set to application/octet-stream.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to