[ https://issues.apache.org/jira/browse/HDFS-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730172#comment-17730172 ]
ASF GitHub Bot commented on HDFS-16946: --------------------------------------- goiri commented on code in PR #5696: URL: https://github.com/apache/hadoop/pull/5696#discussion_r1221853205 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java: ########## @@ -715,8 +716,12 @@ public String getTopTokenRealOwners() { RouterSecurityManager mgr = this.router.getRpcServer().getRouterSecurityManager(); if (mgr != null && mgr.getSecretManager() != null) { - return JSON.toString(mgr.getSecretManager() - .getTopTokenRealOwners(this.topTokenRealOwners)); + try { + return JsonUtil.toJsonString((mgr.getSecretManager() Review Comment: This would read nicer if extracted. ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/TestRouterSecurityManager.java: ########## @@ -81,6 +87,17 @@ public static void createMockSecretManager() throws IOException { @Rule public ExpectedException exceptionRule = ExpectedException.none(); + private Router initializeAndStartRouter(Configuration configuration) { + Router router = new Router(); + try { + router.init(configuration); + router.start(); + } catch (MetricsException e) { + //do nothing Review Comment: We should at least log this. > RBF: top real owners metrics can't been parsed json string > ---------------------------------------------------------- > > Key: HDFS-16946 > URL: https://issues.apache.org/jira/browse/HDFS-16946 > Project: Hadoop HDFS > Issue Type: Bug > Components: rbf > Affects Versions: 3.4.0 > Reporter: Max Xie > Assignee: Nishtha Shah > Priority: Minor > Labels: pull-request-available > Attachments: image-2023-03-09-22-24-39-833.png > > > After HDFS-15447, Add top real owners metrics for delegation tokens. But the > metrics can't been parsed json string. > RBFMetrics$getTopTokenRealOwners method just return > `org.apache.hadoop.metrics2.util.Metrics2Util$NameValuePair@1` > !image-2023-03-09-22-24-39-833.png! -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org