[ 
https://issues.apache.org/jira/browse/HDFS-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730343#comment-17730343
 ] 

ASF GitHub Bot commented on HDFS-17019:
---------------------------------------

ZanderXu commented on PR #5671:
URL: https://github.com/apache/hadoop/pull/5671#issuecomment-1581781377

   Thanks @haiyang1987 for your great job and thanks @ayushtkn for your review.
   




>  Optimize the logic for reconfigure slow peer enable for Namenode
> -----------------------------------------------------------------
>
>                 Key: HDFS-17019
>                 URL: https://issues.apache.org/jira/browse/HDFS-17019
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Haiyang Hu
>            Assignee: Haiyang Hu
>            Priority: Major
>              Labels: pull-request-available
>
> The logic of Reconfigure slow peer enable for Namenode requires the following 
> optimizations:
> 1.Make SlowPeerTracker slowPeerTracker volatile.
> 2.When starting the NameNode, if the parameter 
> dfs.datanode.peer.stats.enabled is set to false, 
> DatanodeManager#startSlowPeerCollector() will not call, as a result the Slow 
> peers collection thread 'slowPeerCollectorDaemon' will not be started .
>  If the parameter dfs.datanode.peer.stats.enabled is dynamically refreshed to 
> true, the current logic will not call 
> DatanodeManager#startSlowPeerCollector(), which to thread 
> 'slowPeerCollectorDaemon' not started as expected, so we will optimize here



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to